Jan Hendrik Farr authored 3 years ago and Timo Teräs committed 3 years ago

Currently, special characters in the username or password are not
handled correctly (when set in $http_proxy and $https_proxy). They
should be percent encoded in the environment variables then decoded
by libfetch and reencoded using base64. This implementation is mainly
taken from the current FreeBSD source and adapted to the apk-tools
version of libfetch.

fixes #10775

readv/writev and struct iovec are declared in sys/uio.h per POSIX.
using it without sys/uio.h is a GNU extension.

ref #10794

Ariadne Conill authored 3 years ago and Timo Teräs committed 3 years ago

clang does not ignore inline functions when checking for unused functions

ref #10794

Ariadne Conill authored 3 years ago and Timo Teräs committed 3 years ago

this ensures the %ju format parameter is always passed an integer that is
appropriately sized, e.g. on mac where off_t is normally 32-bit.

ref #10794

this allows the applet registration to work in a portable way, without having to
weird things with the linker.

ref #10794

Ariadne Conill authored 3 years ago and Timo Teräs committed 3 years ago

on mac, openssl is usually provided by Homebrew or some other third-party
package management system, which means pkg-config is needed to find it.

we already use pkg-config to find openssl when building apk itself.

ref #10794

Ariadne Conill authored 3 years ago and Timo Teräs committed 3 years ago

musl implements support for malloc.h, but it is only a stub.  we do not use
any of the GNU-specific malloc interfaces, so just use POSIX stdlib.h instead.

ref #10794

features.h is a GNU-specific header, and is not required for POSIX-compatible code

macOS does not provide features.h

ref #10794

ref #10794

fixes #10785

fixes #10796

The v3 format will not require the hash, but synthesize it to the
DB so v3 packages can get installed properly.

fixes #10785

The apk_fsdir_file_digest() servers dual purpose: to calculate
the checksum, but also to determine if the file exists. Move
it's error check where it originally was.

fixes #10791

fixes #10778

Symlinks should use the real target filename instead of
the temporary extraction name.

The "untrusted" error is higher priority than malformed package.
But given that we expect valid .apk or index as argument, the
untrusted error is likely more accurate than having malformed
package.

ref #10788

Remove the APK_REPOSITORY_CACHED bit from dependencies only
packages (that is, installed_size == 0). For fetch, the problem
is that apk_db_select_repo() would return the cache repository,
but the package would not be there. Update also the locations
needed to handle these packages correctly without the cached
repository bit being set.

The adb object for apk_pkg_from_adb() was changed in commit 7d6de220
"database: support loading v3 indexes" which also addressed the broken
site in question but omitted updating the argument.

fixes #10783

Always return the original length; not the one with trailing '/'
amended.

fixes c60b7424 "optimize apk_pathbuilder_pop to get the old length"
ref #10784

The apk_istream is null for zero length files, and needs
special handling.

fixes #10784

avoids memrchr

give a fake trust root allowing anything. adbdump code will verify
and dump each signature individually.

by adding an abstraction layer to the file system

When extraction failed, the user has had no opportunity to edit
any files. Just clean up.

fix also the progress callback on uvol extraction

Report also version numbers as invalid if there's more than 18
digits.

fixes #10774