This reverts commit 96d53109.

This reverts commit 34ef9de9.

This reverts commit 35b6b301.

Sertonix authored 5 months ago and Natanael Copa committed 5 months ago

Fixes #10156

This fixes a regression in commit a7e75877.

Sertonix authored 5 months ago and Natanael Copa committed 5 months ago

The CI started to fail cause of test timeout sometimes.

A newline starts a new command in shell scripts and eval uses the shell
grammar. Use a space instead to fix multiline repo templates.

Also avoid one subshell.

Fixes da9269ba

Sertonix authored 5 months ago and Natanael Copa committed 5 months ago

Fixes <da9269ba> abuild: warn when files are installed to non-usr locations

Sertonix authored 5 months ago and Natanael Copa committed 5 months ago

These comments don't have any purpose. They just take up space.

Sertonix authored 5 months ago and Natanael Copa committed 5 months ago

Fixes #10147

Sertonix authored 11 months ago and Natanael Copa committed 5 months ago

When a variables is declared (with 'local' or 'export') a failing
command is ignored[0]. Changing that so abuild should now error out
properly in more cases.

Also remove 1 pipe that could have prevented an issue recently[1] where
the 'du' command core dumped but abuild didn't error.

The other pipes were not changed for now since it may be better to use
'set -o pipefail' instead. That may require some changes with commands
like grep which use a non-zero exit code to indicate if a match was
found or similar[2].

[0]: https://www.shellcheck.net/wiki/SC2155
[1]: alpine/aports#16005 (comment 395899)
[2]: https://github.com/koalaman/shellcheck/issues/665

Sertonix authored 5 months ago and Natanael Copa committed 5 months ago

boost1.82 which used this variable has been removed

The term validate/validation is better than sanity/sane.

Bart Ribbers authored 6 months ago and Natanael Copa committed 5 months ago

As agreed upon by the TSC:
https://gitlab.alpinelinux.org/alpine/tsc/-/blob/master/minutes/2024-08-15.md?ref_type=heads#implement-usr-merge-73
Should be changed to an error once some core packages are adjusted.

Sertonix authored 11 months ago and Natanael Copa committed 5 months ago

The setfattr/getfattr commands were not guaranteed to be available and
abuild wouldn't properly error when they are not. That may cause some
hidden issues.

Changing the code to not need setfattr/getfattr like it is done in
default_dbg ([3ad93d9a]) and pacman mkpkg ([pacman@88d054093c1]).

The code works by first writing the stripped output into a temporary file
and then replace the contents of the already existing file without changing
any file metadata.

[3ad93d9a]: 3ad93d9a
[pacman@88d054093c1]: https://gitlab.archlinux.org/pacman/pacman/-/commit/88d054093c1c99a697d95b26bd9aad5bc4d8e170

Hugo Barrera authored 6 months ago and Natanael Copa committed 5 months ago

Add a reference in the SEE ALSO section. Improves discoverability of
this tool for newcomers.

See: lua-aports!16

Sertonix authored 10 months ago and Natanael Copa committed 5 months ago

Fixes [#10134]

[#10134]: #10134

Sertonix authored 5 months ago and Natanael Copa committed 5 months ago

By setting some environmental variables in default.conf we can reduce the
amount of duplicated code needed in APKBUILDs.

Sertonix authored 6 months ago and Natanael Copa committed 5 months ago

This mechanism was an optional speed optimization for apk-tools which has
been replaced with a better one **before the 2.0 full release** of apk-tools.

This in combination with the fact that the code is endian dependant and
therefor is incompatible with reproducible builds seems enough reason to
remove the code.