feat(AutoMaintainer): support maintainer as variable

Fixes #36

Services/AutoMaintainer/definition.go

@@ -58,7 +58,7 @@ func hasUser(gitlabClient *gitlab.Client, email string) (*gitlab.User, error) {
 }
 
 // ExtractMaintainer takes a ProjectID and a filename and tries to extract the user name
-// and email address of the '# Maintainer:' field
+// and email address of the '# Maintainer:' field, or the 'maintainer=' variable
 func ExtractMaintainer(gitlabClient *gitlab.Client, projectID interface{}, filename, ref string) (*[2]Maintainer, error) {
 	maintainerSlice := [2]Maintainer{}
 
@@ -72,15 +72,16 @@ func ExtractMaintainer(gitlabClient *gitlab.Client, projectID interface{}, filen
 	}
 
 	// Run over every line of the received raw file, we will check the first
-	// occurrence of '# Maintainer'
+	// occurrence of '# Maintainer' or 'maintainer='
 	scanner := bufio.NewScanner(bytes.NewReader(file))
 	for scanner.Scan() {
 		scannedLine := scanner.Text()
 
-		if strings.HasPrefix(scannedLine, "# Maintainer:") {
-			// Strip the # Maintainer: and pass everything else
-			line := strings.ReplaceAll(scannedLine, "# Maintainer:", "")
+		if strings.HasPrefix(scannedLine, "maintainer=") || strings.HasPrefix(scannedLine, "# Maintainer:") {
+			line := strings.TrimPrefix(scannedLine, "maintainer=")
+			line = strings.TrimPrefix(line, "# Maintainer:")
 			line = strings.TrimSpace(line)
+			line = strings.Trim(line, "\"")
 
 			address, err := mail.ParseAddress(line)
 			if err != nil {

Services/AutoMaintainer/definition_test.go

@@ -91,6 +91,27 @@ func Test_ExtractMaintainerSimple(t *testing.T) {
 	assertEqStr(t, "Foo", maintainerSlice[1].GetName())
 }
 
+func Test_ExtractMaintainerVar(t *testing.T) {
+	mux, server, client := mocklab.Setup(t)
+	defer mocklab.Teardown(server)
+
+	mux.HandleFunc("/api/v4/projects/1/repository/files/APKBUILD/raw", func(w http.ResponseWriter, r *http.Request) {
+		if _, err := io.WriteString(w, "maintainer=\"Foo <foo@bar.org>\""); err != nil {
+			t.Fatalf("error writing response: %v", err)
+		}
+	})
+
+	maintainerSlice, err := ExtractMaintainer(client, 1, "APKBUILD", "master")
+	if err != nil {
+		t.Errorf("got unexpected error: %v", err)
+		return
+	}
+	assertEqStr(t, "foo@bar.org", maintainerSlice[0].GetEmail())
+	assertEqStr(t, "Foo", maintainerSlice[0].GetName())
+	assertEqStr(t, "foo@bar.org", maintainerSlice[1].GetEmail())
+	assertEqStr(t, "Foo", maintainerSlice[1].GetName())
+}
+
 func Test_ExtractMaintainerTeam(t *testing.T) {
 	mux, server, client := mocklab.Setup(t)
 	defer mocklab.Teardown(server)