Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • aports aports
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare revisions
  • Issues 666
    • Issues 666
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 306
    • Merge requests 306
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • alpinealpine
  • aportsaports
  • Merge requests
  • !16576

community/dillo: https fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed ph1lter requested to merge ph1lter/aports:community_dillo into master Jan 07, 2021
  • Overview 8
  • Commits 1
  • Pipelines 1
  • Changes 3

The current package for the dillo web browser does not support https/TLS sites.

The current package uses --enable-ssl, but the configure script rejects it and disables ssl/https.

I've added 2 new patches

  configure.patch to allow the enable-ssl feature to pass
  dpi/https.c (changes for new openssl api and fix for hosts requiring name to connect)

I have built, installed and tested the resulting dillo package on all the (https) sites I use and it works.

More details: I've patched the configure script's SSL_library_init test (I do not know how to make autotools handle this correctly) and added a CFLAGS/CXXFLAGS define to select the required openssl api functions.

I've also modified code in dpi/https.c

  • use the api functions to access the common name instead of the old direct struct access, which is no longer supported.
  • call SSL_set_tlsext_host_name() before SSL_connect() for those sites which required the hostname before they will deliver the correct ssl cert.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: community_dillo