According with https://www.consul.io/docs/commands/validate.html the checkconfig
in the init.d script should have been fixed.

This commit updates $license variable in all APKBUILDs to comply with
short names specified by SPDX version 3.0 [1] where possible. It was
done using find-and-replace method on substrings inside $license
variables.

Only license names were updated, not "expressions" specifying relation
between the licenses (e.g. "X and Y", "X or Y", "X and (Y or Z)") or
exceptions (e.g. "X with exceptions").

Many licenses have a version or multiple variants, e.g. MPL-2.0,
BSD-2-Clause, BSD-3-Clause. However, $license in many aports do not
contain license version or variant. Since there's no way how to infer
this information just from abuild, it were left without the variant
suffix or version, i.e. non SPDX compliant.

GNU licenses (AGPL, GFDL, GPL, LGPL) are especially complicated. They
exist in two variants: -only (formerly e.g. GPL-2.0) and -or-later
(formerly e.g. GPL-2.0+). We did not systematically noted distinguish
between these variants, so GPL-2.0, GPL2, GPLv2 etc. may mean
GPL-2.0-only or GPL-2.0-or-later. Thus GNU licenses without "+" (e.g.
GPL2+) were left without the variant suffix, i.e. non SPDX compliant.

Note: This commit just fixes format of the license names, no
verification has been done if the specified license information is
actually correct!

[1]: https://spdx.org/licenses/

TBK authored 7 years ago and Sören Tempel committed 7 years ago

Modernize the APKBUILD while being here.

Gennady Feldman authored 8 years ago and Jakub Jirutka committed 8 years ago

* Updating to latest 0.7.1 release
* Cleaning up APKBUILD (and fixing version)

post-deinstall:
  - Removing user/group is not a good idea. You can't know if the consul
    user/group has been created by the package or not; user can use it even
    for something else.

pre-deinstall:
  - User should decide h[ei]mself if (s)he wants to stop the service
    before uninstalling, it's his/her responsibility and it should not
    be handled automagically in pre-deinstall hook.
  - `&>` is not POSIX-sh compatible, it's a bashism.

Gennady Feldman authored 8 years ago and Jakub Jirutka committed 8 years ago

* Update consul to 0.7.0
* Update init.d script to run configtest and create a log file

github.com/hashicorp/yamux
../../boltdb/bolt/db.go:85: undefined: maxMapSize
../../boltdb/bolt/db.go:85: invalid array bound maxMapSize
github.com/inconshreveable/muxado/proto/buffer

Przemysław Pawełczyk authored 8 years ago and Natanael Copa committed 8 years ago

Now all invocations have following order of arguments (if present):

    addgroup -S -g ... GROUP
    adduser -S -u ... -D -H -h ... -s ... -G ... -g ... USER

Przemysław Pawełczyk authored 8 years ago and Natanael Copa committed 8 years ago

Following rules have been applied:
- script starts with shebang !#/bin/sh followed by blank line,
- script ends with exit 0 prepended by blank line,
- only stderr of adduser, addgroup or passwd is redirected to /dev/null,
- getent passwd/group instances has been removed,
- manual checking of file and group existence has been removed,
- `|| true` instances has been removed.

Comments and line wrapping have been preserved.

Przemysław Pawełczyk authored 8 years ago and Natanael Copa committed 8 years ago

This way we can avoid ugly default:

    Linux user,,,

Przemysław Pawełczyk authored 8 years ago and Natanael Copa committed 8 years ago

It's only for consistency and to ease spotting lack of it.

APKBUILD provided by Olivier Mauras <olivier@mauras.ch>