Skip to content

drop su-exec, improve README and allow override of --port option

Nicolas CARPi requested to merge nicolascarpi/alpine-mksite:nico-docker into master
  • directly use darkhttpd --gid and --uid options to use the "nobody" user/group. This makes the use of su-exec extraneous, so it has been removed
  • move README into README.md and add a Docker section
  • use CMD instruction so the --port option can be overriden more cleanly (without duplication)
  • the --gid and --uid options have been left in the entrypoint as it's unlikely someone would need to change them, and they would need to be repeated if options are given to the run instruction

@ncopa Please let me know what you think of this change. I know you wrote su-exec, but if it's not needed, there is no need to include it (one less thing to worry about) ;)

Note that I've used nobody:nobody instead of previously nobody:www-data, but this has no impact anyway.

Note 2: using README.md now displays it when browsing the repo, which is better than the previously displayed index.md that appeared "broken".

Merge request reports