Skip to content
Snippets Groups Projects

community/[gst-plugins-good|gtk4.0]: Backport rotation support patches

Merged Robert Mader requested to merge rmader/aports:rotation-tags-backports into master
All threads resolved!

Merge request reports

Merge request pipeline #294580 skipped

Merge request pipeline skipped for e7fddce8

Approval is optional

Merged by Bart RibbersBart Ribbers 3 weeks ago (Jan 30, 2025 7:55am UTC)

Merge details

  • Changes merged into master with e7fddce8.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • minor nitpit, but otherwise: LGTM, thanks

  • Robert Mader added 1 commit

    added 1 commit

    • 7858e0e9 - community/gtk4.0: Backport rotation support patches

    Compare with previous version

  • Robert Mader resolved all threads

    resolved all threads

  • Robert Mader marked this merge request as draft

    marked this merge request as draft

  • Author Contributor

    Marking as draft as reviews of the patches are ongoing, so we backport the final versions.

  • Robert Mader added 2 commits

    added 2 commits

    • b8847fb7 - community/gst-plugins-good: Backport mp4 rotation-tag support patch
    • 530d12c4 - community/gtk4.0: Backport rotation support patches

    Compare with previous version

  • Robert Mader added 97 commits

    added 97 commits

    • 530d12c4...4a361965 - 95 commits from branch alpine:master
    • e49bb72e - community/gst-plugins-good: Backport mp4 rotation-tag support patch
    • a19a1458 - community/gtk4.0: Backport rotation support patches

    Compare with previous version

  • Author Contributor

    The Gst patch has landed upstream and is scheduled for backport to the next 1.24 point release. Updated the patch accordingly.

  • Robert Mader marked this merge request as ready

    marked this merge request as ready

  • Author Contributor

    Marking as ready. Unfortunately it might take some time until the second GTK patch land upstream as the maintainers are busy with FOSDEM stuff - and likely the patch will go in without changes anyway (it's very low risk).

    More importantly with community/snapshot: Default to 720p instead 1080p (!79084 - merged) this MR has everything missing to make videos recorded on phones, e.g. with Snapshot, have the right rotation - in the file metadata and when played with gtk-video (e.g. in the Snapshot gallery).

    Thus I'd love to see this land in time for people playing around with pmOS phones at FOSDEM :)

  • Bart Ribbers added 43 commits

    added 43 commits

    • a19a1458...8147d5ce - 41 commits from branch alpine:master
    • 339a85fe - community/gst-plugins-good: Backport mp4 rotation-tag support patch
    • e7fddce8 - community/gtk4.0: Backport rotation support patches

    Compare with previous version

  • merged

  • Author Contributor

    Thanks :heart_hands:

  • Author Contributor

    FTR.: the patches got backported to Gst 1.24.13 and Gtk 4.16.13 and thus can be dropped here once we update to that versions.

  • Thank you!

  • Please register or sign in to reply
    Loading