Skip to content
Snippets Groups Projects

Draft: testing/tempo: new aport

Open raspbeguy requested to merge raspbeguy/aports:tempo into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • raspbeguy resolved all threads

    resolved all threads

  • raspbeguy added 1 commit

    added 1 commit

    • 92684db4 - fixup! TODO: rebase this commit

    Compare with previous version

  • raspbeguy marked this merge request as draft from raspbeguy/aports@92684db4

    marked this merge request as draft from raspbeguy/aports@92684db4

  • raspbeguy added 424 commits

    added 424 commits

    Compare with previous version

  • raspbeguy marked this merge request as ready

    marked this merge request as ready

  • Sertonix
  • raspbeguy added 71 commits

    added 71 commits

    Compare with previous version

  • raspbeguy resolved all threads

    resolved all threads

  • achill (fossdd)
  • 16 pkggroups="grafana"
    17 source="$pkgname-$pkgver.tar.gz::https://github.com/grafana/tempo/archive/refs/tags/v$pkgver.tar.gz
    18 $pkgname.initd
    19 $pkgname.confd
    20 $pkgname-vulture.confd
    21 $pkgname-vulture.initd
    22 "
    23
    24 export GOCACHE="${GOCACHE:-"$srcdir/go-cache"}"
    25 export GOTMPDIR="${GOTMPDIR:-"$srcdir"}"
    26 export GOMODCACHE="${GOMODCACHE:-"$srcdir/go"}"
    27
    28 prepare() {
    29 default_prepare
    30 mkdir -p build
    31 sed -i 's+/var/tempo+/var/lib/tempo+g' example/docker-compose/local/tempo.yaml
    • can you use a patch file instead? that makes it in the future easier to detect if upstream changed the file

    • Author Reporter

      The reason I use sed instead of a patch is because this config file is subject to frequent changes between releases (and releases are frequent). It takes much effort to regenerate a patch each time. Moreover although the config file frequently changes, the path /var/tempo won't, there is no reason it will, because it's made for container deployments without standards paths. It is present multiple times in the file.

      So no, I'd rather not write a patch for that.

    • The problem is that especially if the config file changes that often it can easily be possible that you need to need to corrent the sed command and something isn't doing exactly what is expected. A patch file reduces this risk, also if you might have to rebase it over and over.

      Maybe is it possible to upstream the change?

    • Author Reporter

      As I said previously, this path is very unlikely to change. I don't think there is a chance that this change would be accepted upstream, because this is not important in a docker environment. They ship a deb release which is using /var/tempo (by the way I just found there is a better config file I can use as a starting point), so if they were to change that path that would be a breaking change, so it's even less likely they accept it.

    • raspbeguy changed this line in version 12 of the diff

      changed this line in version 12 of the diff

    • Please register or sign in to reply
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading