Draft: testing/tempo: new aport
Merge request reports
Activity
added 41 commits
-
a2b93e63...8776236c - 40 commits from branch
alpine:master - 42a67656 - testing/tempo: new aport
-
a2b93e63...8776236c - 40 commits from branch
added aports:add label
added 1432 commits
-
42a67656...afcd4b40 - 1431 commits from branch
alpine:master - bfc5540e - testing/tempo: new aport
-
42a67656...afcd4b40 - 1431 commits from branch
marked this merge request as draft from raspbeguy/aports@92684db4
added 424 commits
-
92684db4...4a05bb73 - 423 commits from branch
alpine:master - 47101e17 - testing/tempo: new aport
-
92684db4...4a05bb73 - 423 commits from branch
added 71 commits
-
47101e17...149b4835 - 70 commits from branch
alpine:master - 08e7d04b - testing/tempo: new aport
-
47101e17...149b4835 - 70 commits from branch
- testing/tempo/APKBUILD 0 → 100644
16 pkggroups="grafana" 17 source="$pkgname-$pkgver.tar.gz::https://github.com/grafana/tempo/archive/refs/tags/v$pkgver.tar.gz 18 $pkgname.initd 19 $pkgname.confd 20 $pkgname-vulture.confd 21 $pkgname-vulture.initd 22 " 23 24 export GOCACHE="${GOCACHE:-"$srcdir/go-cache"}" 25 export GOTMPDIR="${GOTMPDIR:-"$srcdir"}" 26 export GOMODCACHE="${GOMODCACHE:-"$srcdir/go"}" 27 28 prepare() { 29 default_prepare 30 mkdir -p build 31 sed -i 's+/var/tempo+/var/lib/tempo+g' example/docker-compose/local/tempo.yaml The reason I use sed instead of a patch is because this config file is subject to frequent changes between releases (and releases are frequent). It takes much effort to regenerate a patch each time. Moreover although the config file frequently changes, the path
/var/tempowon't, there is no reason it will, because it's made for container deployments without standards paths. It is present multiple times in the file.So no, I'd rather not write a patch for that.
-
The problem is that especially if the config file changes that often it can easily be possible that you need to need to corrent the sed command and something isn't doing exactly what is expected. A patch file reduces this risk, also if you might have to rebase it over and over.
Maybe is it possible to upstream the change?
As I said previously, this path is very unlikely to change. I don't think there is a chance that this change would be accepted upstream, because this is not important in a docker environment. They ship a deb release which is using
/var/tempo(by the way I just found there is a better config file I can use as a starting point), so if they were to change that path that would be a breaking change, so it's even less likely they accept it.changed this line in version 12 of the diff
