Skip to content
Snippets Groups Projects

community/kmon: upgrade to 1.7.1

Merged omni requested to merge omni/aports:upgrade-kmon into master

Merge request reports

Merge request pipeline #282424 skipped

Merge request pipeline skipped for 661cf49d

Merged by omniomni 2 months ago (Dec 16, 2024 9:57am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • omni assigned to @omni

    assigned to @omni

  • omni added 2 commits

    added 2 commits

    • 4f4168fa - 1 commit from branch alpine:master
    • 30b8ebcf - community/kmon: upgrade to 1.7.0

    Compare with previous version

  • Author Developer

    hey @orhun, this doubled in size

    >>> Size difference for kmon: 1024 KiB -> 2031 KiB

    is that to be expected?

  • yeah, I think that is the regex crate.

    Before:

    File  .text    Size          Crate Name
    0.0%   0.6% 18.4KiB   clap_builder clap_builder::builder::debug_asserts::assert_app
    0.0%   0.6% 17.6KiB   clap_builder clap_builder::error::format::write_dynamic_context
    0.0%   0.5% 14.9KiB            std std::backtrace_rs::symbolize::gimli::resolve
    0.0%   0.5% 12.9KiB            std std::backtrace_rs::symbolize::gimli::Context::new
    0.0%   0.4% 11.7KiB x11rb_protocol x11rb_protocol::protocol::Event::parse
    0.0%   0.4% 10.1KiB   clap_builder clap_builder::parser::parser::Parser::get_matches_with
    0.0%   0.3%  9.6KiB            std gimli::read::dwarf::Unit<R>::new
    0.0%   0.3%  8.5KiB            std miniz_oxide::inflate::core::decompress
    0.0%   0.3%  8.2KiB   clap_builder alloc::str::join_generic_copy
    0.0%   0.3%  8.2KiB        ratatui alloc::str::join_generic_copy
    0.0%   0.3%  8.2KiB   clap_builder alloc::str::join_generic_copy
    0.0%   0.3%  8.2KiB        termion alloc::str::join_generic_copy
    0.0%   0.3%  8.2KiB   clap_builder alloc::str::join_generic_copy
    0.0%   0.3%  8.2KiB   clap_builder alloc::str::join_generic_copy
    0.0%   0.3%  8.1KiB x11rb_protocol x11rb_protocol::protocol::request_name
    0.0%   0.3%  7.8KiB           kmon kmon::start_tui
    0.0%   0.3%  7.1KiB        ratatui ratatui::layout::layout::configure_flex_constraints
    0.0%   0.2%  7.0KiB            std addr2line::ResUnit<R>::find_function_or_location::{{closure}}
    0.0%   0.2%  6.6KiB           kmon termion::event::parse_csi
    0.0%   0.2%  6.6KiB           kmon termion::event::parse_csi
    5.0%  89.4%  2.5MiB                And 13985 smaller methods. Use -n N to show more.
    5.5% 100.0%  2.8MiB                .text section size, the file size is 49.8MiB

    After:

    File  .text    Size          Crate Name
    0.1%   0.9% 44.7KiB   aho_corasick <aho_corasick::packed::teddy::builder::x86_64::SlimAVX2<4_usize> as aho_corasick::packed::teddy::builder::SearcherT>::find
    0.1%   0.8% 42.0KiB regex_automata regex_automata::hybrid::search::find_fwd
    0.1%   0.8% 41.6KiB   aho_corasick <aho_corasick::packed::teddy::builder::x86_64::SlimAVX2<3_usize> as aho_corasick::packed::teddy::builder::SearcherT>::find
    0.1%   0.7% 38.5KiB   aho_corasick <aho_corasick::packed::teddy::builder::x86_64::SlimAVX2<2_usize> as aho_corasick::packed::teddy::builder::SearcherT>::find
    0.1%   0.7% 37.6KiB   aho_corasick aho_corasick::automaton::try_find_fwd
    0.1%   0.7% 35.1KiB   aho_corasick <aho_corasick::packed::teddy::builder::x86_64::SlimAVX2<1_usize> as aho_corasick::packed::teddy::builder::SearcherT>::find
    0.0%   0.6% 29.8KiB   clap_builder clap_builder::error::format::write_dynamic_context
    0.0%   0.5% 27.5KiB   aho_corasick <aho_corasick::packed::teddy::builder::x86_64::FatAVX2<4_usize> as aho_corasick::packed::teddy::builder::SearcherT>::find
    0.0%   0.5% 26.0KiB   aho_corasick <aho_corasick::packed::teddy::builder::x86_64::FatAVX2<3_usize> as aho_corasick::packed::teddy::builder::SearcherT>::find
    0.0%   0.5% 24.6KiB   aho_corasick <aho_corasick::packed::teddy::builder::x86_64::FatAVX2<2_usize> as aho_corasick::packed::teddy::builder::SearcherT>::find
    0.0%   0.4% 23.1KiB   aho_corasick aho_corasick::automaton::try_find_fwd
    0.0%   0.4% 22.9KiB   aho_corasick <aho_corasick::packed::teddy::builder::x86_64::FatAVX2<1_usize> as aho_corasick::packed::teddy::builder::SearcherT>::find
    0.0%   0.4% 22.5KiB   aho_corasick aho_corasick::automaton::try_find_fwd
    0.0%   0.4% 20.6KiB   aho_corasick aho_corasick::automaton::try_find_overlapping_fwd
    0.0%   0.4% 18.6KiB   clap_builder clap_builder::builder::debug_asserts::assert_app
    0.0%   0.3% 18.0KiB regex_automata regex_automata::nfa::thompson::pikevm::PikeVM::search_imp
    0.0%   0.3% 17.3KiB   aho_corasick <aho_corasick::packed::teddy::builder::x86_64::SlimSSSE3<4_usize> as aho_corasick::packed::teddy::builder::SearcherT>::find
    0.0%   0.3% 17.1KiB regex_automata regex_automata::nfa::thompson::pikevm::PikeVM::which_overlapping_imp
    0.0%   0.3% 16.1KiB regex_automata <regex_automata::meta::strategy::ReverseInner as regex_automata::meta::strategy::Strategy>::search_slots
    0.0%   0.3% 15.8KiB   aho_corasick <aho_corasick::packed::teddy::builder::x86_64::SlimSSSE3<3_usize> as aho_corasick::packed::teddy::builder::SearcherT>::find
    6.7%  86.4%  4.4MiB                And 22942 smaller methods. Use -n N to show more.
    7.8% 100.0%  5.1MiB                .text section size, the file size is 65.2MiB

    Not sure if there are any feature flags that I can tweak to get smaller size.

  • Author Developer

    did a little search and looks like it's possible to make it smaller, depending on what features are needed for kmon, like unicode and speed?

  • omni marked this merge request as draft

    marked this merge request as draft

  • Author Developer

    I tried building it locally with regex-lite and it halfed the size, let's try here

  • omni added 2 commits

    added 2 commits

    • 16ec1976 - community/kmon: upgrade to 1.7.0
    • 219ac425 - community/kmon: build with regex-lite crate

    Compare with previous version

  • Author Developer

    with the regex-lite crate

    >>> Size difference for kmon: 1024 KiB -> 1103 KiB
  • Oh nice, I didn't know about regex-lite crate. Do you mind sending that patch to upstream? I'd be happy to release a patch version with it :)

  • omni added 1 commit

    added 1 commit

    • ea4afbd5 - community/kmon: upgrade to 1.7.1

    Compare with previous version

  • omni changed title from Draft: community/kmon: upgrade to 1.7.0 to Draft: community/kmon: upgrade to 1.7.1

    changed title from Draft: community/kmon: upgrade to 1.7.0 to Draft: community/kmon: upgrade to 1.7.1

  • omni changed the description

    changed the description

  • omni marked this merge request as ready

    marked this merge request as ready

  • LGTM :ship: it

  • omni added 245 commits

    added 245 commits

    Compare with previous version

  • omni added 2 commits

    added 2 commits

    • 60d41797 - 1 commit from branch alpine:master
    • 661cf49d - community/kmon: upgrade to 1.7.1

    Compare with previous version

  • merged

Please register or sign in to reply
Loading