Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
aports
aports
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 647
    • Issues 647
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 205
    • Merge Requests 205
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • alpine
  • aportsaports
  • Merge Requests
  • !66

Closed
Opened Sep 17, 2019 by Johannes Müller@straight-shootaContributor
  • Report abuse
Report abuse

community/crystal: Use CRYSTAL_CONFIG_BUILD_COMMIT to specify build commit

  • Overview 9
  • Commits 1
  • Pipelines 1
  • Changes 1

Running crystal --version (on edge, 0.30.1-r1) gives the following output:

$ crystal --version
Crystal 0.30.1 [284dccd1b9] (2019-08-22)

The build commit (after the version number) incorrectly references the commit of the abuild package (http://git.alpinelinux.org/cgit/aports/commit/?id=284dccd1b95258f680a1aa3f9744f69646e033d1), because it defaults to git rev-parse --short HEAD. But it should reference the Crystal commit. Output from the official Crystal build:

$ crystal --version
Crystal 0.30.1 [5e6a1b672] (2019-08-12)

The fix defines CRYSTAL_CONFIG_BUILD_COMMIT with the commit hash from the Crystal repo.

Edited Sep 17, 2019 by Johannes Müller
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: alpine/aports!66
Source branch: patch-1