Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • aports aports
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
  • Issues 738
    • Issues 738
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 330
    • Merge requests 330
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • alpinealpine
  • aportsaports
  • Merge requests
  • !66

community/crystal: Use CRYSTAL_CONFIG_BUILD_COMMIT to specify build commit

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Johannes Müller requested to merge straight-shoota/aports:patch-1 into master Sep 17, 2019
  • Overview 9
  • Commits 1
  • Pipelines 1
  • Changes 1

Running crystal --version (on edge, 0.30.1-r1) gives the following output:

$ crystal --version
Crystal 0.30.1 [284dccd1b9] (2019-08-22)

The build commit (after the version number) incorrectly references the commit of the abuild package (http://git.alpinelinux.org/cgit/aports/commit/?id=284dccd1b95258f680a1aa3f9744f69646e033d1), because it defaults to git rev-parse --short HEAD. But it should reference the Crystal commit. Output from the official Crystal build:

$ crystal --version
Crystal 0.30.1 [5e6a1b672] (2019-08-12)

The fix defines CRYSTAL_CONFIG_BUILD_COMMIT with the commit hash from the Crystal repo.

Edited Sep 17, 2019 by Johannes Müller
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: patch-1