main/busybox: minor improvements

udhcpd (DHCP server, not client) is part of busybox-extras so move related files to busybox-extras. Also fix the reference to udhcpd leases file to use the correct path.

Indicate that the /etc/network/if-up.d/dad file is used by both busybox-ifupdown and ifupdown-ng.

Sort the generated busybox paths files.

assigned to @nmeum

resolved all threads

added 1 commit

• 8f0acaa9 - main/busybox: minor improvements

Compare with previous version

resolved all threads

changed the description

@nmeum ping!

Thanks for the patch, just some thoughts below.

udhcpd (DHCP server, not client) is part of busybox-extras so move related files to busybox-extras. Also fix the reference to udhcpd leases file to use the correct path.

Sounds good to me.

Indicate that the /etc/network/if-up.d/dad file is used by both busybox-ifupdown and ifupdown-ng.

I don't mind the added comment but could you explain why this is important or how you ran into this?

Sort the generated busybox paths files.

Could you explain what the benefit of this change is?

I don't mind the added comment but could you explain why this is important or how you ran into this?

@sertonix explained in another comment the reasoning behind this.

Sort the generated busybox paths files.

Could you explain what the benefit of this change is?

That the contents of the generated file are sorted in path order? Obviously it is easier to manually "look and make sense of" the contents if the generated contents are sorted.

That the contents of the generated file are sorted in path order? Obviously it is easier to manually "look and make sense of" the contents if the generated contents are sorted.

The file is actually already sorted but in a different way. It is sorted by applet name (not full path) which is nicer to find a specific applet.

ok, well as the contents include the full path it seems logical to sort them by the path.

It's not an important issue, I can remove the "sort" if requested.

@nmeum so what's left to get this merged?

@nmeum ping!

I have a series of further Busybox MRs to raise (rather than raising a single large one) after this one and am wondering how long it is going to end up taking for things to progress as I'd like to get them all in before the Alpine 3.20 release in May.

Sorry, I will take another look at this soon. Unfortunately, I don't have much time this week. I think I would prefer not to include the sort. As far as I can tell, this is also mostly documentation in the sense that there are no functional changes, right? Or is there a reason why this should be prioritized?

Indicate that the /etc/network/if-up.d/dad file is used by both busybox-ifupdown and ifupdown-ng.

I don't mind the added comment but could you explain why this is important or how you ran into this?

Before my comment (!61211 (comment 380072)) the file was moved into busybox-ifupdown which could have broken installs that use ifupdown-ng.

added 519 commits

• 8f0acaa9...61d15b30 - 518 commits from branch alpine:master
• b8f928f6 - main/busybox: minor improvements

Compare with previous version

added 1 commit

• 91600c49 - main/busybox: minor improvements

Compare with previous version

mentioned in merge request !55129 (merged)

Closing as I'm stopping my Alpine involvement.

closed

mentioned in merge request !62224 (merged)

mentioned in merge request !63375