Skip to content

Draft: Make sure all triggers with "*" check for directories

Pablo Correa Gomez requested to merge pabloyoyoista/aports:file-triggers into master

Related apk-tools!131

@ncopa @fabled

What I did:

$ git grep "triggers=.*\\*"                                                                                                                                                           
community/apk-post-messages/APKBUILD:triggers="$pkgname.trigger=/usr/share/doc/*"                                                                                                                                                             
community/appstream/APKBUILD:triggers="$pkgname.trigger=/usr/share/app-info/*:/var/cache/swcatalog/xml"                                                                                                                                       
community/booster/APKBUILD:triggers="$pkgname.trigger=/usr/share/kernel/*"                                                                                                                                                                    
community/dracut/APKBUILD:triggers="$pkgname.trigger=/usr/share/kernel/*"                                                                                                                                                                     
main/akms/APKBUILD:triggers="$pkgname.trigger=/usr/src/*"                                                                                                                                                                                     
main/busybox/APKBUILD:triggers="busybox.trigger=/bin:/usr/bin:/sbin:/usr/sbin:/lib/modules/*"                                                                                                                                                 
main/fontconfig/APKBUILD:triggers="$pkgname.trigger=/usr/share/fonts/*"                                                                                                                                                                       
main/gdk-pixbuf/APKBUILD:triggers="$pkgname.trigger=/usr/lib/gdk-pixbuf-2.0/*/loaders"                                                                                                                                                        
main/gtk+3.0/APKBUILD:triggers="gtk-update-icon-cache.trigger=/usr/share/icons/*"                                                                                                                                                             
main/kernel-hooks/APKBUILD:triggers="$pkgname.trigger=/lib/modules/*"                                                                                                                                                                         
main/kmod/APKBUILD:triggers="$pkgname.trigger=/lib/modules/*"                                                                                                                                                                                 
main/mandoc/APKBUILD:triggers="$pkgname-apropos.trigger=/usr/share/man/*"
main/mkfontscale/APKBUILD:triggers="$pkgname.trigger=/usr/share/fonts/*"
main/mkinitfs/APKBUILD:triggers="$pkgname.trigger=/lib/modules/*"
main/pango/APKBUILD:triggers="$pkgname.trigger=/usr/lib/pango/*/modules"
main/postgresql-common/APKBUILD:triggers="$pkgname.trigger=/usr/libexec/postgresql*:/usr/share/postgresql*"
testing/apk-readme/APKBUILD:triggers="apk-readme.trigger=/usr/share/*/README.alpine"

And then checked all of the manually:

  • busybox already checks for -d
  • gdk-pixbuf, fontconfig, mandoc, pango, appstream in community do not use $@, just execute unconditionally, so I did not consider worth the check
  • apk-readme in testing is a false positive from the grep

Merge request reports