Skip to content

community/synapse: upgrade to 1.98.0 & enable tests

Celeste requested to merge Celeste/aports:upgrade-synapse into master

https://github.com/matrix-org/synapse/releases/tag/v1.97.0

As Alpine 3.19 is just around the corner, i think we should re-enable tests, so we can support this aport for the stable release with tests enabled.

It seems tests are passing with py3-jsonschema 4.19.2, but not on x86*, and i have no idea why, so i have enabled them on all the other architectures for now.

However, there is something a bit strange happening with the tests, compare https://gitlab.alpinelinux.org/Celeste/aports/-/pipelines/197499/builds (built with jsonschema 4.17.3) and https://gitlab.alpinelinux.org/Celeste/aports/-/pipelines/197507/builds (built with jsonschema 4.19.2).

4.17.3 allows the tests to finish in around 4 minutes, whereas 4.19.2 takes 2x (for ppc64le), 3x (for ARM), or 8.5x (for s390x) as long. I wonder if this is also reflected in real world usage of synapse.

So, what should we do? I prefer my original solution of patching synapse to use jsonschema 4.17 like what py3-dt-schema does in !55034 (merged), as it allows the tests to finish quickly and also works on x86*. However, for others, that may seem to be too much patching.

Please discuss this, and hopefully we can have tests enabled in time for 3.19.

Edited by Celeste

Merge request reports