Skip to content

community/evince: finish adding mobile patches

Pablo Correa Gomez requested to merge pabloyoyoista/aports:evince-fixes into master

Fixes 1c081982

The two other already-added patches do not help without the last one. Note that ev_toolbar_set_sidebar_visible and ev_toolbar_set_mobile are never used in those first two patches. One can really verify this behavior dramatically shrinking the size of the window on the desktop. With this last patch, it actually becomes adaptive and shrinks a lot more.

I initially avoided pushing the patches here because I am not sure that the comment: They will be redundant with evince 44 once it uses a gtk4.o ui, which has good mobile support natively is actually accurate. The problem with current evince in mobile is not GTK3, but how the sidebar and the top toolbar are designed. And I don't think the move to GTK4 changes that (although to be honest, I haven't tested the GTK4 MR). To start approaching the issue, I sent some MRs upstream[1][2] that would make the changes smaller, but upstream is having problems with maintenance lately, so it is very slow. So there's a chance that once the move to GTK4 happens, some adaptation of this patches is still necessary. Given it's less than 200 LOC, it should hopefully not be much of an issue.

[1] https://gitlab.gnome.org/GNOME/evince/-/merge_requests/458

[2] https://gitlab.gnome.org/GNOME/evince/-/merge_requests/455

Merge request reports