Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
aports
aports
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 677
    • Issues 677
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 214
    • Merge Requests 214
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • alpine
  • aportsaports
  • Merge Requests
  • !11435

Closed
Opened Aug 14, 2020 by Olliver Schinagl@oliverContributor
  • Report abuse
Report abuse

CODINGSTYLE: Drop non-posix parameter extensions

  • Overview 13
  • Commits 1
  • Pipelines 1
  • Changes 1

While the non-posix substring expansions and replacement expansions are in use in portage already; they currently do not always work properly.

.githooks/pre-commit: 28: testing/gcc-cross-embedded/APKBUILD: Bad substitution

where line 28 reads: targetnorm="${target//-/_}"

So best to avoid this construct when it doesn't even work all the time.

A good replacement is: targetnorm="$(echo "${target}" | tr - _)"

which is posix compliant and works.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: alpine/aports!11435
Source branch: codingstyle