community/opentracker: improve

- clear up license
- show actual version rather than placeholders
- enable WANT_IP_FROM_PROXY option
- modernize

community/opentracker/APKBUILD

 # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
 pkgname=opentracker
 pkgver=0_git20210823
-pkgrel=0
+pkgrel=1
 pkgdesc="an open and free bittorrent tracker"
 url="http://erdgeist.org/arts/software/opentracker/"
 arch="all"
-license="GPL"
+license="Beerware"
 makedepends="libowfat-dev zlib-dev"
 install="$pkgname.pre-install"
 subpackages="$pkgname-openrc ${pkgname}6"
 source="https://dev.alpinelinux.org/opentracker/opentracker-$pkgver.tar.gz
-	opentracker.initd"
+	opentracker.initd
+	show-version.patch
+	"
 
-builddir="$srcdir"/$pkgname
+builddir="$srcdir"
 
 prepare() {
-	cp -r "$builddir" "$builddir"6
+	default_prepare
+	# see show-version.patch
+	sed -i "s/%pkgver%/$pkgver/" opentracker/ot_stats.c
+	cp -r opentracker opentracker6
 }
 
 build() {
-	PREFIX=/usr/include make
-	cd "$builddir"6
-	make PREFIX=/usr/include FEATURES=-DWANT_V6 BINARY=opentracker6
+	export FEATURES="-DWANT_IP_FROM_PROXY"
+	make -C opentracker PREFIX=/usr/include
+
+	export FEATURES="$FEATURES -DWANT_V6"
+	make -C opentracker6 PREFIX=/usr/include BINARY=opentracker6
+}
+
+check() {
+	opentracker/opentracker -v
+	opentracker6/opentracker6 -v
 }
 
 package() {
-	install -d "$pkgdir"/usr/bin
-	install -m755 "$builddir"6/opentracker6 "$pkgdir"/usr/bin/opentracker6
-	make BINDIR="$pkgdir"/usr/bin install
-	install -m644 -D opentracker.conf.sample \
+	install -Dm755 \
+		opentracker/opentracker \
+		opentracker6/opentracker6 \
+		-t "$pkgdir"/usr/bin
+
+	install -Dm644 opentracker/opentracker.conf.sample \
 		"$pkgdir"/etc/opentracker/opentracker.conf
-	install -m755 -D "$srcdir"/$pkgname.initd "$pkgdir"/etc/init.d/$pkgname
+
+	install -Dm755 "$srcdir"/opentracker.initd "$pkgdir"/etc/init.d/opentracker
 	ln -s opentracker "$pkgdir"/etc/init.d/opentracker6
 }
 
 opentracker6() {
-	pkgdesc="IPv6 version of opentracker"
-	install -d "$subpkgdir"/usr/bin
-	mv "$pkgdir"/usr/bin/opentracker6 "$subpkgdir"/usr/bin/
+	pkgdesc="$pkgdesc (IPv6 version)"
+
+	amove usr/bin/opentracker6
 }
 
 sha512sums="
 53b9e163cf6ac349f94ef06075a7f9819e87e26501ae45a27fa0fd79d1bb0ede054739e6e9943f2e1cd51fed21e14c3da91f7a208ee2fcae87c2e659e36ece09  opentracker-0_git20210823.tar.gz
-ec998cc5a80089f2cbeeafa9a558aa0713a698508f4511e68079046e21c35727f4b4667fb9ccbdf0bf293e989839d5678c5602c12a905f6c1d5037d5b543316f  opentracker.initd
+d285ca8ed873e4bc6604a8814aad738459f444fe674379c0798287eb48f116dc84a01ed1c06ad7baf3a015e0eda65fb1f08cb0f220518d9a0b7e0261b481b7d6  opentracker.initd
+86b30cdb4a04d6d08c929c727e941f95134eb7707a3725a8779f2f69c3beb4eac2ec06a991236074e79798aab880223458360a4a5f4dd7e1a05ee9229e8a0c87  show-version.patch
 "

community/opentracker/opentracker.initd

 #!/sbin/openrc-run
 
-name=$RC_SVCNAME
-daemon=/usr/bin/$name
-conf=${opentracker_conf:-/etc/opentracker/$RC_SVCNAME.conf}
-pidfile=/run/$RC_SVCNAME.pid
+conf="${opentracker_conf:-/etc/opentracker/$RC_SVCNAME.conf}"
+
+command="/usr/bin/$RC_SVCNAME"
+command_args="-d /var/empty -f $conf $opentracker_opts"
+command_user="${opentracker_user:-opentracker}"
+command_background="true"
+pidfile="/run/$RC_SVCNAME.pid"
 
 depend() {
 	need net
 	after firewall
 }
-
-start() {
-	ebegin "Starting ${name}"
-	start-stop-daemon --start --quiet \
-		--make-pidfile \
-		--pidfile ${pidfile} \
-		--background \
-		--stdout /dev/null \
-		--stderr /dev/null \
-		--exec ${daemon} \
-		-- \
-		-d /var/empty \
-		-f $conf \
-		-u ${opentracker_user:-opentracker} \
-		${opentracker_opts}
-	eend $?
-}
-
-stop() {
-	ebegin "Stopping ${name}"
-	start-stop-daemon --stop --quiet --pidfile ${pidfile} \
-		--exec ${daemon}
-	eend $?
-}
-

community/opentracker/show-version.patch

+normally, these versions are filled in from cvs
+
+as we have just one tarball, replace that with
+a static string, filled in by a sed in prepare()
+
+diff --git a/opentracker/ot_stats.c b/opentracker/ot_stats.c
+index 7fc22de..e8f41a0 100644
+--- a/opentracker/ot_stats.c
++++ b/opentracker/ot_stats.c
+@@ -563,10 +563,7 @@ extern const char
+ *g_version_scan_urlencoded_query_c, *g_version_trackerlogic_c, *g_version_livesync_c, *g_version_rijndael_c;
+ 
+ size_t stats_return_tracker_version( char *reply ) {
+-  return sprintf( reply, "%s%s%s%s%s%s%s%s%s%s%s%s%s%s",
+-                 g_version_opentracker_c, g_version_accesslist_c, g_version_clean_c, g_version_fullscrape_c, g_version_http_c,
+-                 g_version_iovec_c, g_version_mutex_c, g_version_stats_c, g_version_udp_c, g_version_vector_c,
+-                 g_version_scan_urlencoded_query_c, g_version_trackerlogic_c, g_version_livesync_c, g_version_rijndael_c );
++	return sprintf( reply, "%s", "%pkgver%\n" );
+ }
+ 
+ size_t return_stats_for_tracker( char *reply, int mode, int format ) {