Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • apk-tools apk-tools
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 93
    • Issues 93
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • alpinealpine
  • apk-toolsapk-tools
  • Merge requests
  • !8

Split download and extract into separate steps

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Drew DeVault requested to merge ddevault/apk-tools:fetch-then-extract into master Dec 23, 2019
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 3

This splits apk_db_install_pkg into two steps: APK_INSTALL_DOWNLOAD and APK_INSTALL_COMMIT, and accepts a bitfield of steps to perform. apk_solver_commit_changeset performs these steps as one if the cache is disabled. Otherwise, it downloads everything, then commits everything, in two steps.

By downloading everything upfront, we reduce the risk of leaving the system in a half-installed state should network issues come up partway through the upgrade. Additionally, this makes it safe to interrupt apk during the download step without a similar partially-updated-system problem.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fetch-then-extract