Skip to content
Snippets Groups Projects

pre/post commit hooks both run before and after commit

    • Closed Issue created by Sertonix @sertonix

    The pre commit hooks are not only run before the commit and the post commit hooks are not only run after the commit. I think run_commit_hook is missing a check if the file ending actually matches the current type.

    Also files which don't end in .{pre,post}-commit shouldn't be executed at all.

    Designs

      Child items 0

      2. No child items are currently assigned. Use child items to break down this issue into smaller parts.

      Activity

      • Sertonix changed title from pre/post commit hooks all run before and after commit to pre/post commit hooks both run before and after commit

        changed title from pre/post commit hooks all run before and after commit to pre/post commit hooks both run before and after commit

      • Timo Teräs
        Timo Teräs @fabled ·
        Maintainer

        Seems this is a documentation issue. The original commit to add this is 349c61c9. It works so that all files in the directory are executed and they get as argument the pre-commit or post-commit string.

      • Sertonix
        Sertonix @sertonix ·
        Author Contributor

        Ok, that explains the behaviour.

        This creates the issue that post-commit scripts can't be created before initializing a package database since the used shell may not be available at that point and a failing commit hook causes the installation to abort. Is there a way to make that work?

        Edited by Sertonix
      • Timo Teräs closed with commit 6c454d13

        closed with commit 6c454d13

      • Timo Teräs mentioned in commit 67d66e9b

        mentioned in commit 67d66e9b

      • Timo Teräs mentioned in commit 6c454d13

        mentioned in commit 6c454d13

      Please register or sign in to reply