checkapk: hotfix for incorrect rebuild recommends if file name changed
As pointed out by @kdaudt, checkapk would recommend aport rebuilds if the file name changed without a change in the SONAME. This commit attempts to workaround this by sorting the file output and processing .so files as pairs of two (previous .so, new .so). For both files, the SONAME is extracted using scanelf(1) and then compared for equality. If the SONAME is not equal, rebuilds are recommended.
Merge request reports
Activity
- Resolved by Natanael Copa
Manually tested the following:
- If the soname and the file name changed, then rebuilds are recommended
- If the file name changed and the soname didn't then rebuilds are not recommended
Should probably also add a test case but checkapk requires an older version of the package to already exist in the repo, not sure how to best do that in the test setup. any ideas?
I added two basic test cases (soname changed / soname not changed) but the logic in checkapk is really hard to test. Maybe it really makes sense to revert acfa7d67 and keep checkapk simple.
Edited by Sören Tempelwhat do you recommend? merge this or revert acfa7d67?
mentioned in commit ncopa/abuild@5c19c8a2
mentioned in merge request !258 (merged)
mentioned in commit ncopa/abuild@22e17446
fixed with !258 (merged)