Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • abuild abuild
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 64
    • Issues 64
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 39
    • Merge requests 39
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • alpinealpine
  • abuildabuild
  • Merge requests
  • !168

abump: fix abump environment being poluted by APKBUILD

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kevin Daudt requested to merge abump-isolate-source into master Oct 15, 2022
  • Overview 0
  • Commits 2
  • Pipelines 1
  • Changes 2

abump sources the APKBUILD to be able to check some variables. When the APKBUILD exports variables in the global scope, that affects the abump environment as well.

When abump then executes abuild, it will inherrit the environment from abump. This is an issue under the following circumstances:

  • The APKBUILD only updates the value of an exported variable if it's not set
  • The default value includes a variable set by abuild, like $srcdir.

Because the variable is set by abuild, but not abump, the resulting exported variable is different. Because it's then set incorrectly in the abump environment, it's no longer updated with the correct variable when abuild is invoked.

Address this by sourcing the APKBUILD in a subshell.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: abump-isolate-source