Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • abuild abuild
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 56
    • Issues 56
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • alpinealpine
  • abuildabuild
  • Merge requests
  • !137

abuild: add subpkgver capabilities

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Antoine Martin requested to merge ayakael/abuild:subpkgver into master Feb 06, 2022
  • Overview 13
  • Commits 1
  • Pipelines 0
  • Changes 1

Adds the option to set custom subpackage version.

As with arch, defined within the subpackages array using the following syntax: subpkgname:subpkgsplit:subpkgarch:subpkgver.

Also brings the following improvements to subpkg_set function:

  • subpkgarch can be set without setting subpkgsplit
  • proper checking if subpkgarch is actually supported arch using new is_arch function
  • proper checking if subpkgver is actually version information by checking if variable contains '.'
  • as long as syntax order is respected, any extra variables can be undefined

Possible improvements:

  • is_arch relies on hardcoded local supportedArch array. It'd be nice if this was sourced from somewhere else so that future (un)supported architectures can automatically be detected.
  • subpkg_set certainly has room for optimizations. For readability, things were kept as-is to make sure there are no syntax bugs.
  • while default_sanitycheck was updated to check subpkgver, likely other aport sanity check scripts need updating
  • ideally subpkg_set should not need an explicit order to the arguments. With 2 out of 3 arguments being detectable, it would be possible for subpkg_set to go through all of the arguments and be able to read which arg is associated to which option. This would complexify the function, thus move away from KISS principles, which is why I didn't go this direction.

Accompanies lua-aports!4 Fixes part of: #10060

Edited Feb 07, 2022 by Antoine Martin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: subpkgver