Sören Tempel authored 1 year ago and Natanael Copa committed 1 year ago

Since the changeset committed by psykose a while ago in commit
26118d49 we now extract the
previous soname. We can pass this previous soname to `apk search -R`
to figure out how many packages are linked against this old soname.

I believe this to be useful for reviewing MRs since the checkapk
output will directly tell us if a contributor has missed rebuilds.
It will also inform us when no rebuilds are necessary, e.g. if the
SONAME was changed but no packages is linked against the library.

Example output for `main/libsodium`:

```
>>> Size difference for libsodium: 336 KiB -> 340 KiB
--- filelist-libsodium-old      2023-09-22 11:24:54.799204225 +0200
+++ filelist-libsodium-new      2023-09-22 11:24:54.799204225 +0200
@@ -1,5 +1,5 @@
 .PKGINFO
 usr/
 usr/lib/
-usr/lib/libsodium.so.23
-usr/lib/libsodium.so.23.3.0
+usr/lib/libsodium.so.26
+usr/lib/libsodium.so.26.1.0
SODIFF:
-usr/lib/libsodium.so.23.3.0:    SONAME               libsodium.so.23
+usr/lib/libsodium.so.26.1.0:    SONAME               libsodium.so.26
REBUILDS:
*** 36 packages linked against 'libsodium.so.23' need to be rebuild!
```

also add tests

print --help output to stdout and errors to stderr.

skip various steps when buliding the package.

Test that passing only `CHOST=... abuild deps` works as expected

verify that checkdepends is pulled in when it should and not installed
when it shouldn't.

verify that makedepends_build and makedepends_host works as expected.

ref: alpine/abuild#10102

ref alpine/abuild#10102

ref: alpine/abuild#10102

Patrycja Rosa authored 2 years ago and Patrycja Rosa committed 1 year ago

related to #10069, this keeps the original behaviour when
running in aports and allows for using rootbld in other package repositories

Otherwise, it wouldn't do much…

sudotac authored 1 year ago and Natanael Copa committed 1 year ago

smartmatch is deprecated in Perl 5.37.10

- _LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS: This macro is used to enable -Wthread-safety annotations on libc++’s std::mutex and std::lock_guard.
- _LIBCPP_ENABLE_HARDENED_MODE to enable the hardened mode.

grep: warning: stray \ before -
it matches without \ anyway

otherwise it cleans up but the loop keeps going and just fails until end,
just spamming the output

it was a mismatch of mixed indents

the former is deprecated syntax

the prefix was dropped from the check so it always says it's unregistered
no actual breakage happened as this just prints a warning

the previous implementation had a bug that + chars needed escaping
(which was fixed), and now has another discovered but that pkgnames
could start with a number, so the /^pkg/ match matches the pkgname again
and a size comparison gives you:

>>> Size difference for 7zip: 7zip-22.01-r5 installed size: -> 7zip-23.01-r0 installed size:

using grep -F avoids any magic character expansion and works correctly
in all cases.

cleans up the output a bit for things that have .so in the name

this is quite trivial and should be safe

prior to the recent reworks, this error handling path was never
triggered, because the script is ran without pipefail, and it was at
the end of a | pipe | line | sort, so all it did was be ignored for 'new
apks', when the old one would fail to fetch and be missing.

since we now do hit this path on fetch failure however, it aborts the
script when a new subpackage/package is added (since the 'old apk' won't
exist), and doesn't output a diff. since before we always ignored this,
ignore the 'old apk' perhaps not existing, which gives the currently
intended behaviour.

boolean logic gets confusing..

this affected the old version too- duplicate sodiffs on symlinks are useless