alpine issueshttps://gitlab.alpinelinux.org/groups/alpine/-/issues2024-03-24T16:07:05Zhttps://gitlab.alpinelinux.org/alpine/aports/-/issues/15901[Package request]: dissent - a gtk4 Discord client2024-03-24T16:07:05ZMarek Ľach[Package request]: dissent - a gtk4 Discord client**Package name**: dissent
**License**: GPLv3
**Dependencies**: go
**Source code**: https://github.com/diamondburned/dissent
**Releases**: https://github.com/diamondburned/dissent/releases
**Why package it**: A native, responsive Dis...**Package name**: dissent
**License**: GPLv3
**Dependencies**: go
**Source code**: https://github.com/diamondburned/dissent
**Releases**: https://github.com/diamondburned/dissent/releases
**Why package it**: A native, responsive Discord client for Linuxhttps://gitlab.alpinelinux.org/alpine/aports/-/issues/15900KTrip edge: missing dependencies "qqc2-desktop-style" and "sonnet"2024-03-24T19:34:03ZBrad HoyKTrip edge: missing dependencies "qqc2-desktop-style" and "sonnet"Title; KTrip (at least on aarch64) refuses to open without these two packages installed.Title; KTrip (at least on aarch64) refuses to open without these two packages installed.Bart RibbersBart Ribbershttps://gitlab.alpinelinux.org/alpine/apk-tools/-/issues/10984meson: openssl_static dependency in libfetch results in double linking2024-03-21T12:07:36ZDaniel Kolesameson: openssl_static dependency in libfetch results in double linkingThe recent changes brought in a libfetch dependency on openssl, however this results in openssl for now harmlessly being linked twice. Worse would be if it tried to link the second openssl statically, which it does not for now. Either wa...The recent changes brought in a libfetch dependency on openssl, however this results in openssl for now harmlessly being linked twice. Worse would be if it tried to link the second openssl statically, which it does not for now. Either way, it should only link once.
potential patch:
```
From 58feb1d66f8ec5e1f607dabd8c83ae725c3dc1ac Mon Sep 17 00:00:00 2001
From: q66 <q66@chimera-linux.org>
Date: Thu, 21 Mar 2024 12:04:58 +0100
Subject: [PATCH] libfetch: fix openssl dependency specification
We shouldn't include the full static linkage as it may accidentally
bring static openssl into the apk link path. We only care about the
includes here, so do that.
---
libfetch/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libfetch/meson.build b/libfetch/meson.build
index 7406fbb..59ea789 100644
--- a/libfetch/meson.build
+++ b/libfetch/meson.build
@@ -38,7 +38,7 @@ libfetch = static_library(
'fetch',
libfetch_src,
c_args: libfetch_cargs,
- dependencies: openssl_static_dep,
+ dependencies: openssl_dep.partial_dependency(compile_args: true, includes: true),
)
libfetch_dep = declare_dependency(
--
2.44.0
```https://gitlab.alpinelinux.org/alpine/apk-tools/-/issues/10983can no longer extract packages as user since --usermode changes2024-03-21T12:36:12ZDaniel Kolesacan no longer extract packages as user since --usermode changesThe usermode changes were made for apk add, but do not account for manual package extraction.The usermode changes were made for apk add, but do not account for manual package extraction.https://gitlab.alpinelinux.org/alpine/aports/-/issues/15899main/protobuf-c: static library has LTO info, fails to link2024-03-27T19:29:02ZValery Ushakovmain/protobuf-c: static library has LTO info, fails to link## Package Information
* Package name: protobuf-c-dev
* Package version: 1.4.1-r7
* Alpine version: 3.20.0_alpha20240315
* Alpine architecture: x86_64
## Summary
Static library libprotobuf-c.a contins LTO info from the older compiler,...## Package Information
* Package name: protobuf-c-dev
* Package version: 1.4.1-r7
* Alpine version: 3.20.0_alpha20240315
* Alpine architecture: x86_64
## Summary
Static library libprotobuf-c.a contins LTO info from the older compiler, fails to link with the newer compiler (gcc-13.2.1_git20240309-r0)
## Steps to reproduce
```
$ cat proto.c
#include <stdio.h>
#include <protobuf-c/protobuf-c.h>
int
main(void)
{
printf("%s\n", protobuf_c_version());
return 0;
}
$ cc -static -o proto proto.c -lprotobuf-c
lto1: fatal error: bytecode stream in file '/usr/lib/gcc/x86_64-alpine-linux-musl/13.2.1/../../../../lib/libprotobuf-c.a' generated with LTO version 13.0 instead of the expected 13.1
compilation terminated.
lto-wrapper: fatal error: cc returned 1 exit status
compilation terminated.
/usr/lib/gcc/x86_64-alpine-linux-musl/13.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
```Leonardo ArenaLeonardo Arenahttps://gitlab.alpinelinux.org/alpine/apk-tools/-/issues/10982apk3: conflicts are broken since recently2024-03-20T18:37:56ZDaniel Kolesaapk3: conflicts are broken since recentlySome of the recent changes broke package conflicts. Instead, the `!` is stripped and it's considered a dependency. The actual package metadata in adb is still correct.Some of the recent changes broke package conflicts. Instead, the `!` is stripped and it's considered a dependency. The actual package metadata in adb is still correct.https://gitlab.alpinelinux.org/alpine/apk-tools/-/issues/10981apk3: running triggers now always leaves apk in error state2024-03-20T13:40:45ZDaniel Kolesaapk3: running triggers now always leaves apk in error state```
root@cbuild: ~$ apk fix base-shells
The following packages will be reinstalled:
base-shells
After this operation, 0 B of additional disk space will be used.
Do you want to continue [Y/n]? y
(1/1) Reinstalling base-shells (0.1-r0)
E...```
root@cbuild: ~$ apk fix base-shells
The following packages will be reinstalled:
base-shells
After this operation, 0 B of additional disk space will be used.
Do you want to continue [Y/n]? y
(1/1) Reinstalling base-shells (0.1-r0)
Executing base-shells-0.1-r0.trigger
Regenerating /etc/shells...
1 error; 1286 MiB in 145 packages
root@cbuild: ~$ apk fix
After this operation, 0 B of additional disk space will be used.
OK: 1286 MiB in 145 packages
root@cbuild: ~$ apk fix base-shells
The following packages will be reinstalled:
base-shells
After this operation, 0 B of additional disk space will be used.
Do you want to continue [Y/n]? y
(1/1) Reinstalling base-shells (0.1-r0)
Executing base-shells-0.1-r0.trigger
Regenerating /etc/shells...
1 error; 1286 MiB in 145 packages
```
Relevant commit is probably 60fec0bd3de1c3f8f6747fbc170765c69e0de438https://gitlab.alpinelinux.org/alpine/apk-tools/-/issues/10980apk3: segfaults since recent updates2024-03-20T15:06:42ZDaniel Kolesaapk3: segfaults since recent updatesTried to update in Chimera from c8c9df1825760e558f44397500af2a2f4bca18d4 to latest master.
Immediately encountered a segfault:
```
root@cbuild: ~$ apk add perl
The following NEW packages will be installed:
less perl
After this operat...Tried to update in Chimera from c8c9df1825760e558f44397500af2a2f4bca18d4 to latest master.
Immediately encountered a segfault:
```
root@cbuild: ~$ apk add perl
The following NEW packages will be installed:
less perl
After this operation, 51 MiB of additional disk space will be used.
Do you want to continue [Y/n]? y
(1/2) Installing less (643-r0)
(2/2) Installing perl (5.38.2-r0)
8% ███████████████ Segmentation fault (core dumped)
root@cbuild: ~$ lldb -c core.12
(lldb) target create --core "core.12"
Core file '/tmp/core.12' (x86_64) was loaded.sl-x86_64.so.1...
(lldb) bt
* thread #1, name = 'apk', stop reason = signal SIGSEGV: address not mapped to object
* frame #0: 0x00007c4e64fcbce1 libapk.so.2`apk_db_dir_prepare(db=0x000059597e8d3830, dir=0x00007c4e644c5c70) at database.c:276:20
frame #1: 0x00007c4e64fd949f libapk.so.2`apk_db_install_file(ectx=0x00007ffec51c63a0, ae=0x00007ffec51c3de8, is=0x0000000000000000) at database.c:2757:3
frame #2: 0x00007c4e64fdb5b4 libapk.so.2`apk_extract_v3_next_file [inlined] apk_extract_v3_directory(ectx=0x00007ffec51c63a0) at extract_v3.c:128:6
frame #3: 0x00007c4e64fdb3dc libapk.so.2`apk_extract_v3_next_file(ectx=0x00007ffec51c63a0) at extract_v3.c:164:8
frame #4: 0x00007c4e64fdb196 libapk.so.2`apk_extract_v3_data_block(db=0x00007ffec51c4088, b=<unavailable>, is=0x00007ffec51c3f60) at extract_v3.c:192:6
frame #5: 0x00007c4e64fbd630 libapk.so.2`adb_m_process at adb.c:244:7
frame #6: 0x00007c4e64fbd22c libapk.so.2`adb_m_process(db=0x00007ffec51c4088, is=0x00007c4e64832f30, expected_schema=<unavailable>, t=0x000059597e8d35b8, cb=<unavailable>) at adb.c:280:9
frame #7: 0x00007c4e64fdaf1d libapk.so.2`apk_extract_v3(ectx=0x00007ffec51c63a0, is=0x00007c4e64f04fc0) at extract_v3.c:253:6
frame #8: 0x00007c4e64fd4fe2 libapk.so.2`apk_db_install_pkg [inlined] apk_extract(ectx=<unavailable>, is=0x00007c4e64f04fc0) at extract_v3.c:292:41
frame #9: 0x00007c4e64fd4fdd libapk.so.2`apk_db_install_pkg [inlined] apk_db_unpack_pkg(db=0x000059597e8d3830, ipkg=0x00007c4e62fd2010, upgrade=<unavailable>, cb=(libapk.so.2`progress_cb at commit.c:129:37), cb_ctx=0x00007ffec51c64c0, script_args=0x00007ffec51c5240) at database.c:2996:6
frame #10: 0x00007c4e64fd4e21 libapk.so.2`apk_db_install_pkg(db=0x000059597e8d3830, oldpkg=0x0000000000000000, newpkg=0x00007c4e6399e610, cb=(libapk.so.2`progress_cb at commit.c:129:37), cb_ctx=0x00007ffec51c64c0) at database.c:3047:7
frame #11: 0x00007c4e64fc880a libapk.so.2`apk_solver_commit_changeset(db=0x000059597e8d3830, changeset=0x00007ffec51c65a0, world=0x00007c4e62a77a40) at commit.c:377:9
frame #12: 0x00007c4e64fca62e libapk.so.2`apk_solver_commit(db=0x000059597e8d3830, solver_flags=0, world=0x00007c4e62a77a40) at commit.c:813:7
frame #13: 0x000059597e861359 apk`add_main(ctx=0x00007c4e651039f0, ac=<unavailable>, args=0x00007c4e65163e50) at app_add.c:209:6
frame #14: 0x000059597e86073a apk`main(argc=1, argv=0x00007ffec51c7348) at apk.c:616:6
frame #15: 0x00007c4e65457bca ld-musl-x86_64.so.1`libc_start_main_stage2(main=(apk`main at apk.c:493), argc=<unavailable>, argv=0x00007ffec51c7338) at __libc_start_main.c:95:7
frame #16: 0x000059597e85fa76 apk`_start + 22
(lldb) p dir->owner
(apk_db_dir_instance *) NULL
```https://gitlab.alpinelinux.org/alpine/aports/-/issues/15897Edge kde5 -» 6 sddm breeze segv2024-03-26T16:14:50ZBjörn StrömbergEdge kde5 -» 6 sddm breeze segvUpdated a older edge kde rootfs and it unfortunately does not want to start sddm after.
It segv sddm-helper according to /var/log/sddm.log err code 11
And /var/lib/sddm/.local/sddm.log
Says it can't create child in another thread
@Pur...Updated a older edge kde rootfs and it unfortunately does not want to start sddm after.
It segv sddm-helper according to /var/log/sddm.log err code 11
And /var/lib/sddm/.local/sddm.log
Says it can't create child in another thread
@PureTryOut anything you have encountered?Bart RibbersBart Ribbershttps://gitlab.alpinelinux.org/alpine/aports/-/issues/15896community/kgamma5: package no longer exists2024-03-21T05:05:48ZPatrycja Rosaalpine@ptrcnull.mecommunity/kgamma5: package no longer exists`kgamma5` is included in explicitly `setup-desktop` - its removal causes existing setups to keep an orphaned package in apk world, not being able to do anything with it and potentially blocking dependencies, but also making existing inst...`kgamma5` is included in explicitly `setup-desktop` - its removal causes existing setups to keep an orphaned package in apk world, not being able to do anything with it and potentially blocking dependencies, but also making existing installations fail on `apk add` and being very sad about it:
![image](/uploads/e20d3d2c1cd67f63ead23b03619089bb/image.png)Bart RibbersBart Ribbershttps://gitlab.alpinelinux.org/alpine/alpine-conf/-/issues/10576setup-desktop: update list of KDE packages2024-03-20T08:22:38ZPatrycja Rosaalpine@ptrcnull.mesetup-desktop: update list of KDE packagesfor example, `kgamma5` no longer existsfor example, `kgamma5` no longer existshttps://gitlab.alpinelinux.org/alpine/aports/-/issues/15895packaging 'dotnet' based software do we have a standard way yet?2024-03-21T06:53:13ZBjörn Strömbergpackaging 'dotnet' based software do we have a standard way yet?as we have dotnet6-runtime/sdk in v3.18/9 and will have dotnet8-runtime/sdk in v3.20 in a while..
* have there been any packaging of dotnet alpine packages yet to flesh out the gremlins of nuget -> apk when it comes to shared packages?...as we have dotnet6-runtime/sdk in v3.18/9 and will have dotnet8-runtime/sdk in v3.20 in a while..
* have there been any packaging of dotnet alpine packages yet to flesh out the gremlins of nuget -> apk when it comes to shared packages?
* is this something we want?
* or is native (AOT) output good enough?
i know three paths:
* dotnet build with nuget to fetch dependencies (shared libs but duplicated per application, pretty much like how a windows app installation looks, and its horrible waste of space)
* dotnet build with nuget to fetch dependencies (AOT) with native output (much static linking, producing large binaries, with a few so files, not as bad as the previous one. the likely solution in the short term
* apk based install of dynamic libraries from nuget and somehow getting everything to work (sounds like an utopia, but we do it like that with pypi etc so i guess its a question if its worth the work?)
any input in the matter? @ayakael or anyone else using dotnet?https://gitlab.alpinelinux.org/alpine/aports/-/issues/15894[Package Request] Velox2024-03-22T20:14:05ZDave[Package Request] Velox## Package Information
* Name: velox
* Homepage: https://github.com/michaelforney/velox
## Description
`velox` is a simple window manager based on `swc`. It is inspired by `dwm` and `xmonad`.
I have tried to build from git but I'm ju...## Package Information
* Name: velox
* Homepage: https://github.com/michaelforney/velox
## Description
`velox` is a simple window manager based on `swc`. It is inspired by `dwm` and `xmonad`.
I have tried to build from git but I'm just a normie and I'm hitting errors I cant seem to get past, but I'm sure someone who is more familiar with Apline's build environment will have no trouble at all.
* description edits are just me fumbling around trying to add the package request tag.https://gitlab.alpinelinux.org/alpine/aports/-/issues/15893community/wezterm: conflicts with community/foot2024-03-20T16:34:33ZIngacommunity/wezterm: conflicts with community/foot## Package Information
* Package name: community/wezterm, community/foot
* Package version: wezterm-20240203.110809-r0 and foot-1.16.2-r1 respectively
* Alpine version: 3.20.0_alpha20240315
* Alpine architecture: x86_64
## Summary
com...## Package Information
* Package name: community/wezterm, community/foot
* Package version: wezterm-20240203.110809-r0 and foot-1.16.2-r1 respectively
* Alpine version: 3.20.0_alpha20240315
* Alpine architecture: x86_64
## Summary
community/wezterm depends on community/wezterm-common which depends on community/wezterm-extra-terminfo which provides /usr/share/terminfo/w/wezterm.
community/foot depends on main/ncurses-terminfo which provides /usr/share/terminfo/w/wezterm.
So now when I have both foot and wezterm upgraded to the latest version, my `apk -s upgrade` produces results like that:
```
(1/3) Upgrading zstd-libs (1.5.5-r8 -> 1.5.5-r9)
(2/3) Upgrading giflib (5.2.1-r5 -> 5.2.2-r0)
(3/3) Upgrading linux-lts (6.6.22-r0 -> 6.6.22-r1)
1 error; 2690 MiB in 607 packages
```
## Steps to reproduce
Not sure if this is reproducible on a fresh install; maybe it just won't let you to install one of these two when another is already installed?
(I had them both installed before that conflict, so it broke for me during the upgrade.)Matthias Ahouansoumatthias@ahouansou.czMatthias Ahouansoumatthias@ahouansou.czhttps://gitlab.alpinelinux.org/alpine/aports/-/issues/15891testing/ddcci-driver-linux-src fails to build with linux-edge-dev-6.8.1-r02024-03-19T16:40:22ZHugo Barreratesting/ddcci-driver-linux-src fails to build with linux-edge-dev-6.8.1-r0## Package Information
* Package name*: **ddcci-driver-linux-src-0.4.4-r2** and **linux-edge-dev-6.8.1-r0**
* Alpine version*: edge / 3.20.0_alpha20240315
* Alpine architecture*: x86_64
## Summary
```
> doas apk fix ddcci-driver-linux...## Package Information
* Package name*: **ddcci-driver-linux-src-0.4.4-r2** and **linux-edge-dev-6.8.1-r0**
* Alpine version*: edge / 3.20.0_alpha20240315
* Alpine architecture*: x86_64
## Summary
```
> doas apk fix ddcci-driver-linux-src
WARNING: opening /home/hugo/packages/main: No such file or directory
(1/1) Reinstalling ddcci-driver-linux-src (0.4.4-r2)
Executing akms-0.2.1-r0.trigger
akms: Building module ddcci-driver-linux/0.4.4-r2 for kernel 6.8.1-0-edge
WARNING: opening /home/hugo/packages/main: No such file or directory
WARNING: opening /home/hugo/packages/main: No such file or directory
(1/8) Installing libasm (0.191-r0)
(2/8) Installing elfutils-dev (0.191-r0)
(3/8) Installing flex (2.6.4-r6)
(4/8) Installing bison (3.8.2-r1)
(5/8) Installing linux-edge-dev (6.8.1-r0)
(6/8) Installing .akms-build (20240319.154618)
(7/8) Installing bison-doc (3.8.2-r1)
(8/8) Installing flex-doc (2.6.4-r6)
OK: 13718 MiB in 3090 packages
make: Entering directory '/usr/src/linux-headers-6.8.1-0-edge'
CC [M] /var/lib/akms/6.8.1-0-edge/ddcci-driver-linux/0.4.4-r2/build/ddcci/ddcci.o
/usr/src/ddcci-driver-linux-0.4.4/ddcci/ddcci.c: In function 'ddcci_detect':
/usr/src/ddcci-driver-linux-0.4.4/ddcci/ddcci.c:1669:9: error: implicit declaration of function 'strlcpy'; did you mean 'strscpy'? [-Werror=implicit-function-declaration]
1669 | strlcpy(info->type, (outer_addr == DDCCI_DEFAULT_DEVICE_ADDR) ? "ddcci" : "ddcci-dependent", I2C_NAME_SIZE);
| ^~~~~~~
| strscpy
/usr/src/ddcci-driver-linux-0.4.4/ddcci/ddcci.c: At top level:
/usr/src/ddcci-driver-linux-0.4.4/ddcci/ddcci.c:1827:27: error: 'I2C_CLASS_DDC' undeclared here (not in a function); did you mean 'I2C_CLASS_SPD'?
1827 | .class = I2C_CLASS_DDC,
| ^~~~~~~~~~~~~
| I2C_CLASS_SPD
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:243: /var/lib/akms/6.8.1-0-edge/ddcci-driver-linux/0.4.4-r2/build/ddcci/ddcci.o] Error 1
make[1]: *** [/usr/src/linux-headers-6.8.1-0-edge/Makefile:1921: /var/lib/akms/6.8.1-0-edge/ddcci-driver-linux/0.4.4-r2/build/ddcci] Error 2
make: *** [Makefile:240: __sub-make] Error 2
make: Leaving directory '/usr/src/linux-headers-6.8.1-0-edge'
akms: ERROR: Failed to build module ddcci-driver-linux/0.4.4-r2 for 6.8.1-0-edge
akms: ERROR: examine /var/lib/akms/6.8.1-0-edge/ddcci-driver-linux/0.4.4-r2/build
```https://gitlab.alpinelinux.org/alpine/aports/-/issues/15890community/dotnet8 missing the DOTNET_CLI_TELEMETRY_OPTOUT in /etc/profile.d/d...2024-03-20T00:08:40ZBjörn Strömbergcommunity/dotnet8 missing the DOTNET_CLI_TELEMETRY_OPTOUT in /etc/profile.d/dotnet.shthe built packages from 2024.03.14 in community does not default to opting out of telemetry! ping @ayakael
content:
```
# Set location for AppHost lookup
[ -z "$DOTNET_ROOT" ] && export DOTNET_ROOT=/usr/lib/dotnet
# Add dotnet tools di...the built packages from 2024.03.14 in community does not default to opting out of telemetry! ping @ayakael
content:
```
# Set location for AppHost lookup
[ -z "$DOTNET_ROOT" ] && export DOTNET_ROOT=/usr/lib/dotnet
# Add dotnet tools directory to PATH
DOTNET_TOOLS_PATH="$HOME/.dotnet/tools"
case "$PATH" in
*"$DOTNET_TOOLS_PATH"* ) true ;;
* ) PATH="$PATH:$DOTNET_TOOLS_PATH" ;;
esac
# Extract self-contained executables under HOME to avoid multi-user issues from using the default '/var/tmp'
[ -z "$DOTNET_BUNDLE_EXTRACT_BASE_DIR" ] && export DOTNET_BUNDLE_EXTRACT_BASE_DIR="${XDG_CACHE_HOME:-"$HOME"/.cache}/dotnet_bundle_extract"
```
caught this output during the build of dotnet from source
```
#
# Telemetry
# ---------
# The .NET tools collect usage data in order to help us improve your experience.
# It is collected by Microsoft and shared with the community.
# You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.
#
```
so the file should export `export DOTNET_CLI_TELEMETRY_OPTOUT=true` system wide on startup since service might be running without telemetry off!
... Microsoft and their damn telemetry ...https://gitlab.alpinelinux.org/alpine/aports/-/issues/15889trying to understand nuget errors (dotnet8-stage0 [sdk part])2024-03-22T08:47:13ZBjörn Strömbergtrying to understand nuget errors (dotnet8-stage0 [sdk part])i recognize the type of errors from an earlier time i played around with dotnet on linux, but never really dug into what they mean..
anyway tried building dotnet8 on v3.18 (just for the sake of testing limits in a otherwise clean contai...i recognize the type of errors from an earlier time i played around with dotnet on linux, but never really dug into what they mean..
anyway tried building dotnet8 on v3.18 (just for the sake of testing limits in a otherwise clean container) then v3.19 just to see if that works, now i'm going to run on edge, which i expect to work, but the errors i actually does not understand. `PackageProjectUrl` error seems wierd to work on edge but not 3.18/3.19
so adding this issue here just to see if anyone who might have traveled into the dotnet world knows what this is, cause duckduckgo and google does not give me any good answers that would imply that it will be gone on the edge build with other dependencies.
```
Writing file: /home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/artifacts/bin/redist/Release/net8.0/vstest.console.runtimeconfig.json
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Cli/Microsoft.DotNet.InternalAbstractions/Microsoft.DotNet.InternalAbstractions.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(80,5): error : RepositoryUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/template_feed/Microsoft.DotNet.Common.ItemTemplates/Microsoft.DotNet.Common.ItemTemplates.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Cli/Microsoft.DotNet.Cli.Sln.Internal/Microsoft.DotNet.Cli.Sln.Internal.csproj]
13:16:42.554 18>Compressing /home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/artifacts/bin/redist/Release/layouts/dotnet-toolset-internal into /home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/artifacts/packages/Release/NonShipping/dotnet-toolset-internal-8.0.100-rtm.23551.6.zip...
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(80,5): error : RepositoryUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/template_feed/Microsoft.DotNet.Common.ProjectTemplates.8.0/Microsoft.DotNet.Common.ProjectTemplates.8.0.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/WebSdk/Worker/Tasks/Microsoft.NET.Sdk.Worker.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/WebSdk/Publish/Tasks/Microsoft.NET.Sdk.Publish.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Cli/Microsoft.DotNet.Configurer/Microsoft.DotNet.Configurer.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/RazorSdk/Tasks/Microsoft.NET.Sdk.Razor.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Resolvers/Microsoft.DotNet.MSBuildSdkResolver/Microsoft.DotNet.MSBuildSdkResolver.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/WasmSdk/Tasks/Microsoft.NET.Sdk.WebAssembly.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/WebSdk/Web/Tasks/Microsoft.NET.Sdk.Web.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/StaticWebAssetsSdk/Tasks/Microsoft.NET.Sdk.StaticWebAssets.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Resolvers/Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver/Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/WebSdk/ProjectSystem/Tasks/Microsoft.NET.Sdk.Web.ProjectSystem.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Cli/dotnet/dotnet.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/Microsoft.NET.Sdk.WorkloadManifestReader.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Microsoft.DotNet.TemplateLocator/Microsoft.DotNet.TemplateLocator.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Cli/Microsoft.TemplateEngine.Cli/Microsoft.TemplateEngine.Cli.csproj]
Compressing /home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/artifacts/bin/redist/Release/layouts/dotnet-toolset-langpack into /home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/artifacts/packages/Release/NonShipping/dotnet-toolset-langpack-8.0.100-rtm.23551.6.zip...
13:16:55.504 38>Microsoft.DotNet.ApiCompat.Task -> /home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/artifacts/bin/Microsoft.DotNet.ApiCompat.Task/Release/net8.0/publish/
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/BlazorWasmSdk/Tasks/Microsoft.NET.Sdk.BlazorWebAssembly.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Tasks/Microsoft.NET.Build.Extensions.Tasks/Microsoft.NET.Build.Extensions.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/ApiCompat/Microsoft.DotNet.ApiCompat.Task/Microsoft.DotNet.ApiCompat.Task.csproj]
Build FAILED.
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Cli/Microsoft.DotNet.InternalAbstractions/Microsoft.DotNet.InternalAbstractions.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(80,5): error : RepositoryUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/template_feed/Microsoft.DotNet.Common.ItemTemplates/Microsoft.DotNet.Common.ItemTemplates.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Cli/Microsoft.DotNet.Cli.Sln.Internal/Microsoft.DotNet.Cli.Sln.Internal.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(80,5): error : RepositoryUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/template_feed/Microsoft.DotNet.Common.ProjectTemplates.8.0/Microsoft.DotNet.Common.ProjectTemplates.8.0.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/WebSdk/Worker/Tasks/Microsoft.NET.Sdk.Worker.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/WebSdk/Publish/Tasks/Microsoft.NET.Sdk.Publish.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Cli/Microsoft.DotNet.Configurer/Microsoft.DotNet.Configurer.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/RazorSdk/Tasks/Microsoft.NET.Sdk.Razor.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Resolvers/Microsoft.DotNet.MSBuildSdkResolver/Microsoft.DotNet.MSBuildSdkResolver.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/WasmSdk/Tasks/Microsoft.NET.Sdk.WebAssembly.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/WebSdk/Web/Tasks/Microsoft.NET.Sdk.Web.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/StaticWebAssetsSdk/Tasks/Microsoft.NET.Sdk.StaticWebAssets.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Resolvers/Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver/Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/WebSdk/ProjectSystem/Tasks/Microsoft.NET.Sdk.Web.ProjectSystem.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Cli/dotnet/dotnet.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/Microsoft.NET.Sdk.WorkloadManifestReader.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Microsoft.DotNet.TemplateLocator/Microsoft.DotNet.TemplateLocator.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Cli/Microsoft.TemplateEngine.Cli/Microsoft.TemplateEngine.Cli.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/BlazorWasmSdk/Tasks/Microsoft.NET.Sdk.BlazorWebAssembly.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Tasks/Microsoft.NET.Build.Extensions.Tasks/Microsoft.NET.Build.Extensions.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj]
/home/drone/custom-packages/dotnet/dotnet8-stage0/src/nuget/microsoft.dotnet.arcade.sdk/8.0.0-beta.23516.4/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/home/drone/custom-packages/dotnet/dotnet8-stage0/src/dotnet-8.0.0/src/sdk/src/ApiCompat/Microsoft.DotNet.ApiCompat.Task/Microsoft.DotNet.ApiCompat.Task.csproj]
0 Warning(s)
23 Error(s)
```Antoine MartinAntoine Martinhttps://gitlab.alpinelinux.org/alpine/aports/-/issues/15888coq package is incapable of building plugins2024-03-27T19:29:01ZJason Grosscoq package is incapable of building plugins
## Package Information
* Package name: coq
* Package version: `apk info` does not list package versions, see [here](https://github.com/mit-plv/fiat-crypto/actions/runs/8336730797/job/22814340740?pr=1834#step:5:243)
* Alpine version: *A...
## Package Information
* Package name: coq
* Package version: `apk info` does not list package versions, see [here](https://github.com/mit-plv/fiat-crypto/actions/runs/8336730797/job/22814340740?pr=1834#step:5:243)
* Alpine version: *Alpine version from `/etc/alpine-release`* (Will edit in once [CI finishes](https://github.com/mit-plv/fiat-crypto/actions/runs/8338003431/job/22817630366))
* Alpine architecture: *Architecture obtained via `apk --print-arch`* (Will edit in once [CI finishes](https://github.com/mit-plv/fiat-crypto/actions/runs/8338003431/job/22817630366))
## Summary
The `coq` package needs to be rebuilt on top of the latest `ocaml` package, since the current version is incapable of loading plugins, erroring with "Error: Dynlink error: implementation mismatch on Stdlib__List", see [here](https://github.com/mit-plv/fiat-crypto/actions/runs/8336730797/job/22814340740?pr=1834#step:6:1022)
## Steps to reproduce
Clone https://github.com/mit-plv/rewriter, run `make`https://gitlab.alpinelinux.org/alpine/aports/-/issues/15887Consider renaming community/glycin to glycin-loaders2024-03-20T06:27:45ZNewbyteConsider renaming community/glycin to glycin-loaderscommunity/glycin doesn't actually contain any glycin dynamic libraries but rather just the image loaders. After a chat with upstream the recommendation seems to be naming this package glycin-loaders (which is also what it's packaged as i...community/glycin doesn't actually contain any glycin dynamic libraries but rather just the image loaders. After a chat with upstream the recommendation seems to be naming this package glycin-loaders (which is also what it's packaged as in Debian and Fedora) rather than glycin, which I think makes sense given that the current name makes it sound more like it would contain the actual library.Patrycja Rosaalpine@ptrcnull.mePatrycja Rosaalpine@ptrcnull.mehttps://gitlab.alpinelinux.org/alpine/aports/-/issues/15886Migrate aport testing/manticoresearch to testing/manticore; Adopt package2024-03-18T20:45:16ZTherminoel.kuntze@thermi.consultingMigrate aport testing/manticoresearch to testing/manticore; Adopt packageZach already provided feedback he'd be okay with itZach already provided feedback he'd be okay with it