Commit 4fe5ac83 authored by Ariadne Conill's avatar Ariadne Conill 🐰 Committed by Timo Teräs

database: do not chroot(".") unless actually necessary

If we use default root (/), then we do not have to chroot to run scripts.
Use APK_NO_CHROOT flag for this scenario to avoid the chroot.  This helps
with using apk with bwrap and OSTree.

Closes #10736.
parent 51162143
Pipeline #76014 passed with stage
in 1 minute and 8 seconds
......@@ -25,6 +25,7 @@
#define APK_NO_SCRIPTS BIT(8)
#define APK_NO_CACHE BIT(9)
#define APK_NO_COMMIT_HOOKS BIT(10)
#define APK_NO_CHROOT BIT(11)
#define APK_FORCE_OVERWRITE BIT(0)
#define APK_FORCE_OLD_APK BIT(1)
......
......@@ -42,6 +42,7 @@ int apk_ctx_prepare(struct apk_ctx *ac)
if (!ac->keys_dir) ac->keys_dir = "etc/apk/keys";
if (!ac->root) ac->root = "/";
if (!ac->cache_max_age) ac->cache_max_age = 4*60*60; /* 4 hours default */
if (!strcmp(ac->root, "/")) ac->flags |= APK_NO_CHROOT; /* skip chroot if root is default */
ac->root_fd = openat(AT_FDCWD, ac->root, O_RDONLY | O_CLOEXEC);
if (ac->root_fd < 0 && (ac->open_flags & APK_OPENF_CREATE)) {
......
......@@ -1906,8 +1906,18 @@ int apk_db_run_script(struct apk_database *db, char *fn, char **argv)
}
if (pid == 0) {
umask(0022);
if (fchdir(db->root_fd) == 0 && chroot(".") == 0)
execve(fn, argv, environment);
if (fchdir(db->root_fd) != 0) {
apk_err(out, "%s: fchdir: %s", basename(fn), strerror(errno));
exit(127);
}
if (!(db->ctx->flags & APK_NO_CHROOT) && chroot(".") != 0) {
apk_err(out, "%s: chroot: %s", basename(fn), strerror(errno));
exit(127);
}
execve(fn, argv, environment);
exit(127); /* should not get here */
}
waitpid(pid, &status, 0);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment