GitLab

Oliver Smith authored May 02, 2019 and Natanael Copa committed Jun 12, 2019

Add a '# Check sections' comment, for consistency with the equally
commented build and package sections.

Oliver Smith authored May 02, 2019 and Natanael Copa committed Jun 12, 2019

Since the obsolete 'cd "$builddir"' statements have been removed in [1],
build(), check() and package() can generate empty functions if no build
system is specified or if there is no default for the given build
system. newapkbuild will then fail, as it tries to parse the script it
generated:

$ cd /home/pmos && newapkbuild test
/usr/bin/abuild: /home/pmos/test/APKBUILD: line 18: syntax error: unexpected "}"
$ cat test/APKBUILD
...
build() {
}
...

Fix this by placing ":" in functions that would be empty.

[1]: f83d19ce

allow a single APKBUILD have multiple -openrc subpackages.

Leo authored Apr 29, 2019 and Natanael Copa committed Apr 30, 2019

awk: cmd. line:1: warning: regexp escape sequence `\#' is not a known regexp operator

Run the loop in a subshell via a pipe so we dont need a subshell for
each iteration.

Use `if ...; then` to make code slightly more readable.

Fix a whitespace before tab while at it.

tcely authored Apr 29, 2019 and Natanael Copa committed Apr 30, 2019

Resolves alpinelinux/abuild#71

tcely authored Apr 29, 2019 and Natanael Copa committed Apr 29, 2019

- do not overwrite variables

srcdir is very important for abuild operation

- quoted various paths
- use a sub-shell to contain directory changing

Resolves alpinelinux/abuild#58

Kevin Daudt authored Mar 03, 2019 and Natanael Copa committed Apr 29, 2019

Some projects might leave files which are not writable for the current
user. The cleanup process then fails and leaves files / directories
behind.

This can easily be fixed by making everything writable before removing
the files.

Add the option 'chmod-clean' which does just that.

Leo authored Apr 26, 2019 and Natanael Copa committed Apr 29, 2019

- Also check for static archives and warn on lack of static subpackage

Kevin Daudt authored Apr 22, 2019 and Natanael Copa committed Apr 29, 2019

Since `$builddir` is officially supported and abuild automatically cd's to `$builddir`, it does not need to be part of the template anymore.

Mike Sullivan authored Apr 22, 2019 and Natanael Copa committed Apr 29, 2019

This reverts commit 57f28307.

https://github.com/alpinelinux/aports/pull/7203 fixes the original problem

Luca Weiss authored Apr 06, 2019 and Natanael Copa committed Apr 29, 2019

From what I could find, it was changed to -musleabihf during the Alpine
3.6 release cycle but this function was never updated to reflect that

Apparently there are many packages that does soemthing like:

subpackages="$pkgname-foo:_foo"

_foo() {
	depends="$depends something-else"
}

and thus depend on the previous behavior. We need to revert and plan
this better.

This reverts commit 8fbbffd2.

Other subpackage such as -dev, -doc and even -openrc allow adjusting
depends of the subpackage through such a variable. This is, for
instance, useful to remove a dependency of the origin package from the
-libs subpackage.

While at it document it in APKBUILD(5).

Chloe Kudryavtsev authored Dec 08, 2018 and Natanael Copa committed Apr 03, 2019

In some cases, a simple rm -rf is not sufficent to clean srcdir.
One such case is the new go module system, that marks everything as
read-only - thus only letting root rm -rf it without a chmod.
There is a command intended to clean them - `go clean -modcache`.
However, for that to work, GOPATH must be defined and existent.
Running chmod for all srcdir cleanups makes no sense, nor does enforcing
root, or putting global overrides just for go.

This patch allows overriding what happens on `cleanup srcdir`, by
overriding cleanup_srcdir, and allows the use of default_cleanup_srcdir.

In our go example, it might be used as such:

cleanup_srcdir() {
	go clean -modcache
	default_cleanup_srcdir
}

Chloe Kudryavtsev authored Dec 08, 2018 and Natanael Copa committed Apr 03, 2019

Avoid DRY issues, and increase consistency.

make sure that subpackages does not inherit main package's depends.

replace litteral version string with $pkgver in source url

we need to check if a given module currently is a part of core. Modules
which have a first_release may have been removed later, for example
Module::Build.

the generation of Makefile is comparable with running configure, which
we normally do in the build() function, not in prepare.

also fix some whitespace damamge.

Robert Hencke authored Feb 22, 2019 and Natanael Copa committed Mar 14, 2019

This prevents clang from issuing a warning here.