1. 03 Apr, 2019 2 commits
    • Chloe Kudryavtsev's avatar
      Add default_cleanup_srcdir · 6a6310f0
      Chloe Kudryavtsev authored
      In some cases, a simple rm -rf is not sufficent to clean srcdir.
      One such case is the new go module system, that marks everything as
      read-only - thus only letting root rm -rf it without a chmod.
      There is a command intended to clean them - `go clean -modcache`.
      However, for that to work, GOPATH must be defined and existent.
      Running chmod for all srcdir cleanups makes no sense, nor does enforcing
      root, or putting global overrides just for go.
      This patch allows overriding what happens on `cleanup srcdir`, by
      overriding cleanup_srcdir, and allows the use of default_cleanup_srcdir.
      In our go example, it might be used as such:
      cleanup_srcdir() {
      	go clean -modcache
    • Chloe Kudryavtsev's avatar
      Make clean() use cleanup() · 30d296dd
      Chloe Kudryavtsev authored
      Avoid DRY issues, and increase consistency.
  2. 21 Mar, 2019 4 commits
  3. 20 Mar, 2019 5 commits
  4. 14 Mar, 2019 1 commit
  5. 05 Mar, 2019 4 commits
  6. 25 Feb, 2019 1 commit
  7. 22 Feb, 2019 1 commit
    • Natanael Copa's avatar
      abuild: add support for pkg-config prefix pcprefix · 376ccc5b
      Natanael Copa authored
      Fix issue when two -dev packages provides same pkg-config wil but with
      different versions. For example libressl-dev and openssl-dev both ships
      libssl.pc and libcrypto.pc, which resulted in automatic provides of
      pc:libssl and pc:libcrypto.
      apk would end up picking libressl-dev over openssl-dev for packages that
      had automatic pc:libssl depends (for example libssl2-dev), when
      openssl-dev was the one that was used during build.
      To fix this we add support for a pcprefix so we can set
      pcprefix="libressl:" in libressl APKBUILD which makes libressl-dev
      provide pc:libressl:libssl. This is similar to what we do with
      We do not yet automatically detect when the prefixed variant should be
      used so for now we will have to explicitly add libressl-dev.
      ref #9959
  8. 23 Jan, 2019 1 commit
  9. 10 Jan, 2019 3 commits
  10. 09 Jan, 2019 2 commits
  11. 02 Dec, 2018 1 commit
  12. 08 Nov, 2018 2 commits
  13. 11 Oct, 2018 1 commit
    • Sören Tempel's avatar
      abuild-rmtemp: Do not follow symbolic links · 17cb68e9
      Sören Tempel authored
      Symbolic links might point to files outside of the chroot and
      thus might delete files outside the chroot. This allows deletion
      of arbitrary directories on the host from a malicious APKBUILD.
      Following hard links shouldn't be a problem since hard links (usually)
      cannot refer to directories and since remove(3) removes the link, not
      the file it points to it shouldn't cause a problem.
      I noticed this because alpine-baselayout creates /var/run as a symlink
      to /run. Therefore causing /run to be deleted on the host when using
      abuild-rmtemp which in turn causes a bunch of software to no longer
      function properly (including OpenRC).
  14. 03 Oct, 2018 12 commits