Commit 0bf61ee0 authored by Natanael Copa's avatar Natanael Copa

abuild: do not run check in fakeroot by default

Only run check in fakeroot if options="checkroot" is set. This makes
options="!checkroot" the default.

I expect most checks work as non-root, and if a testsuite requires root,
it will likely fail in fakeroot too. Fakeroot has also shown lower
performance for parallel builds.
parent 3379e675
...@@ -298,11 +298,10 @@ Do not use this option. ...@@ -298,11 +298,10 @@ Do not use this option.
.It Cm !check .It Cm !check
Specifies that the package will not run a test suite. Specifies that the package will not run a test suite.
The reason for disabling the check phase should be noted in a comment. The reason for disabling the check phase should be noted in a comment.
.It Cm !checkroot .It Cm checkroot
Specifies that the package's test suite will be run as a non-privileged user Specifies that the package's test suite will be run in
instead of using
.Xr fakeroot 8 . .Xr fakeroot 8 .
This is necessary for some test suites which fail when run as root. This is necessary for some test suites which fail when run as non-root.
.It Cm !dbg .It Cm !dbg
Specifies that the package should not be built with a debug information Specifies that the package should not be built with a debug information
package. package.
......
...@@ -1508,9 +1508,9 @@ create_apks() { ...@@ -1508,9 +1508,9 @@ create_apks() {
} }
build_abuildrepo() { build_abuildrepo() {
local d apk _check=check_fakeroot local _check=check
if options_has "!checkroot"; then if options_has "checkroot"; then
_check=check _check=check_fakeroot
fi fi
if ! want_check; then if ! want_check; then
_check=true _check=true
...@@ -2125,9 +2125,9 @@ checksum() { ...@@ -2125,9 +2125,9 @@ checksum() {
} }
rootbld_actions() { rootbld_actions() {
local part _check=check_fakeroot local part _check=check
if options_has "!checkroot"; then if options_has "checkroot"; then
_check=check _check=check_fakeroot
fi fi
if ! want_check; then if ! want_check; then
_check=true _check=true
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment