Commit 409ede5b authored by Leo's avatar Leo

move some checks back to Minor

parent add18279
CHANGES in 18.1:
- Move some style checks that belonged to leo to minor since they are
now part of the CODINGSTYLE.md
CHANGES in 18.0:
- Add a Style severity label denoted by a T character
......
......@@ -32,7 +32,9 @@ situations. Should be fixed soon.
## Minor (M)
Won't directly cause issues during build or when the package is delivered to users.
Should be fixed when convenient
Should be fixed when convenient.
This also holds style issues that are dictated on the CODINGSTYLE.md file.
## STYLE (T)
......@@ -257,22 +259,14 @@ The APKBUILD has a space character between the name of a function
and the paranthesis that denote it is a function. Remove the superfluous
space.
Severity: Style, Certainty: Certain
Present in the _APKBUILD\_STYLE_ of:
- leo
Severity: MInor, Certainty: Certain
## space-after-function-parenthesis [AL11]
The APKBUILD doesn't have a space after the function parenthesis or has more
than one space. Use only one space after the function parenthesis.
Severity: Style, Certainty: Certain
Present in the _APKBUILD\_STYLE_ of:
- leo
Severity: Minor, Certainty: Certain
## newline-opening-brace [AL12]
......@@ -280,11 +274,7 @@ The APKBUILD has a newline before the opening brace of a function. Put the
opening brace in the same line as the declaration with one space after the
function parenthesis.
Severity: Style, Certainty: Certain
Present in the _APKBUILD\_STYLE_ of:
- leo
Severity: Minor, Certainty: Certain
## superfluous-cd-builddir [AL13]
......
......@@ -219,9 +219,6 @@ _run_apkbuild_leo() {
# Run all tests from Leo
pkgname_quoted &
pkgver_quoted &
space_before_function_parenthesis &
space_after_function_parenthesis &
newline_opening_brace &
}
ret=0
......@@ -248,6 +245,9 @@ for apkbuild; do
function_keyword &
pkgname_has_uppercase &
pkgver_has_pkgrel &
space_before_function_parenthesis &
space_after_function_parenthesis &
newline_opening_brace &
# Don't perform these checks on packages from main
if ! [ -z "${apkbuild##*main/*}" ]; then
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment