Commit 068ca085 authored by Leo's avatar Leo

be more strict with empty strings but more relaxed with empty strings.

- Don't match strings that don't start at the beginning of a line, it
  has a legitimate use-case of strings used in subpackages that need to
  be empty
- But match empty strings that declare themselves empty by having "" as
  their value, this was previously ignored because it was how
  subpackages would declare themselves but it would miss lots of
  subpackages
parent 54c1f5eb
...@@ -172,7 +172,7 @@ for apkbuild; do ...@@ -172,7 +172,7 @@ for apkbuild; do
scan '\|\| return 1' "|| return 1 is not required as set -e is used" scan '\|\| return 1' "|| return 1 is not required as set -e is used"
scan '^pkgname="[^$]+"' "pkgname must not be quoted" scan '^pkgname="[^$]+"' "pkgname must not be quoted"
scan '^pkgver="[^$]+"' "pkgver must not be quoted" scan '^pkgver="[^$]+"' "pkgver must not be quoted"
scan '^[^ =]*=(|''|)$' "variable set to empty string: \2" scan '^[^=]*=(|""|''|)$' "variable set to empty string: \2"
scan '^(?!\s*^('"$variables"'))[^\s=-]+=' \ scan '^(?!\s*^('"$variables"'))[^\s=-]+=' \
"prefix custom variable with _: \2" "prefix custom variable with _: \2"
scan '^ ' "indent with tabs" scan '^ ' "indent with tabs"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment