atools issueshttps://gitlab.alpinelinux.org/Leo/atools/-/issues2019-10-20T20:44:03Zhttps://gitlab.alpinelinux.org/Leo/atools/-/issues/3Refactor check loops to deal with sorting packages only once2019-10-20T20:44:03ZLeoRefactor check loops to deal with sorting packages only once*Created by: maxice8*
*Created by: maxice8*
https://gitlab.alpinelinux.org/Leo/atools/-/issues/31Add warning if there is no empty line before sha512sums2020-05-24T10:10:13ZTBKAdd warning if there is no empty line before sha512sums```shell
package() {
python3 setup.py install --prefix=/usr --root="$pkgdir"
}
sha512sums="5.........
```
```shell
package() {
python3 setup.py install --prefix=/usr --root="$pkgdir"
}
sha512sums="5.........
``````shell
package() {
python3 setup.py install --prefix=/usr --root="$pkgdir"
}
sha512sums="5.........
```
```shell
package() {
python3 setup.py install --prefix=/usr --root="$pkgdir"
}
sha512sums="5.........
```https://gitlab.alpinelinux.org/Leo/atools/-/issues/41detect overriding of declared variables2021-01-26T07:56:52ZLeodetect overriding of declared variablesVarious packages had more than 1 options declaration in the root of the document.
While it was normally harmless as both were passing the same option some were not.
As an example one had the first option have `!check` while the second ...Various packages had more than 1 options declaration in the root of the document.
While it was normally harmless as both were passing the same option some were not.
As an example one had the first option have `!check` while the second one had `suid`.
Check if one of our special variables is found more than once and check if it is not being overridden.https://gitlab.alpinelinux.org/Leo/atools/-/issues/43Detect when pkgdesc starts with "A …"2021-03-11T19:26:14ZjvoisinDetect when pkgdesc starts with "A …"Since this is apparently [frowned upon]( https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/18488#note_144907 ), albeit there is currently ~1k packages with this.Since this is apparently [frowned upon]( https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/18488#note_144907 ), albeit there is currently ~1k packages with this.https://gitlab.alpinelinux.org/Leo/atools/-/issues/46Checking the temperature to if we want to follow common shell do's/don't2022-02-09T16:32:10ZOlliver SchinaglChecking the temperature to if we want to follow common shell do's/don'tHey @Leo just checking if I should put effort into a MR to cleanup the codebase to be more stringent on style. E.g. the age-old `$var` vs `"${var}"` but also other small things. Also running shellcheck in 'strict' mode (enable=all) for e...Hey @Leo just checking if I should put effort into a MR to cleanup the codebase to be more stringent on style. E.g. the age-old `$var` vs `"${var}"` but also other small things. Also running shellcheck in 'strict' mode (enable=all) for example.https://gitlab.alpinelinux.org/Leo/atools/-/issues/39Detect "Subject: [PATCH X/Y]" in patch files2023-07-31T07:25:55ZOliver SmithDetect "Subject: [PATCH X/Y]" in patch filesWhen using `git format-patch` with multiple patches, it will generate subject lines like `[PATCH 1/3]`. This isn't useful for aports, because once the amount of patches changes (e.g. because a patch got upstreamed), the total number is w...When using `git format-patch` with multiple patches, it will generate subject lines like `[PATCH 1/3]`. This isn't useful for aports, because once the amount of patches changes (e.g. because a patch got upstreamed), the total number is wrong and running `git format-patch` for the remaining patches rebased on the new source would change the total count in all patch files. It leads to bigger diffs.
So I suggest we warn about this, and recommend using `git format-patch -N` instead to omit the numbers.https://gitlab.alpinelinux.org/Leo/atools/-/issues/3553don't flag backticks in comments2023-09-08T10:13:16Zomniomni+alpine@hack.orgdon't flag backticks in commentsBackticks are quite common in comments in APKBUILD files, probably out of habit since this is how you quote code in markdown. Suggesting to use `$()` instead usually doesn't make sense where backticks are used in comments.Backticks are quite common in comments in APKBUILD files, probably out of habit since this is how you quote code in markdown. Suggesting to use `$()` instead usually doesn't make sense where backticks are used in comments.https://gitlab.alpinelinux.org/Leo/atools/-/issues/25Add apkbuild-shellcheck?2023-11-24T21:38:52ZOliver SmithAdd apkbuild-shellcheck?atools is great and we began using apkbuild-lint outside of Alpine, in the pmaports repository of postmarketOS.
It would be great if we could also use apkbuild-shellcheck in the future, however the code for that is in the docker image "...atools is great and we began using apkbuild-lint outside of Alpine, in the pmaports repository of postmarketOS.
It would be great if we could also use apkbuild-shellcheck in the future, however the code for that is in the docker image "apkbuild-lint-tools" and not part of atools:
https://gitlab.alpinelinux.org/alpine/infra/docker/apkbuild-lint-tools/tree/master
@kdaudt, @Leo: are there plans to move apkbuild-shellcheck to atools, and/or would you accept patches to do this?