Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
A
atools
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
5
Issues
5
List
Boards
Labels
Service Desk
Milestones
Merge Requests
1
Merge Requests
1
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Leo
atools
Commits
67050789
Commit
67050789
authored
Jun 09, 2019
by
Leo
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
make default-builddir-value and superfluous-cd-builddir minor
parent
b7a8c33e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
4 deletions
+4
-4
alint.5.scd
alint.5.scd
+2
-2
apkbuild-lint
apkbuild-lint
+2
-2
No files found.
alint.5.scd
View file @
67050789
...
...
@@ -153,7 +153,7 @@ The *builddir* declaration can be removed.
Starting
with
v2
.
29.0
of
*
abuild
*
the
value
is
set
automatically
.
Severity:
Important
,
Certainty:
Certain
Severity:
Minor
,
Certainty:
Certain
##
unnecessary
-
return
-1
[
AL2
]
...
...
@@ -261,7 +261,7 @@ functions automatically have their working directory set to the value of
*
builddir
*
.
It
is
also
possible
that
there
are
2
*
cd
"$builddir"
*
statements
one
after
the
other
.
Severity:
Important
,
Certainty:
Possible
Severity:
Minor
,
Certainty:
Possible
##
pkgname
-
has
-
uppercase
[
AL14
]
...
...
apkbuild-lint
View file @
67050789
...
...
@@ -63,7 +63,7 @@ default_builddir_value() {
[
"
$SKIP_DEFAULT_BUILDDIR_VALUE
"
]
&&
return
0
[
"
$SKIP_AL1
"
]
&&
return
0
if
[
"
$builddir
"
=
"/
$pkgname
-
$pkgver
"
]
;
then
scan
'^builddir='
"builddir can be removed as it is the default value"
'AL1'
'
I
C'
scan
'^builddir='
"builddir can be removed as it is the default value"
'AL1'
'
M
C'
fi
}
...
...
@@ -180,7 +180,7 @@ superfluous_cd_builddir() {
[
-z
"
$statement
"
]
&&
continue
if
echo
"
$statement
"
|
grep
-E
-q
'cd ["]?\$[{]?builddir["}]?+($| )'
;
then
if
[
"
$prevcd
"
-eq
1
]
||
[
"
$cdscount
"
-eq
1
]
||
[
"
$firstcd
"
-eq
1
]
;
then
printf
"
I
P:[AL13]:%s:%s:cd
\"\$
builddir
\"
can be removed in phase '%s'
\\
n"
\
printf
"
M
P:[AL13]:%s:%s:cd
\"\$
builddir
\"
can be removed in phase '%s'
\\
n"
\
"
$apkbuild
"
\
"
$linenum
"
\
"
$phase
"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment