Skip to content
  • Kevin Daudt's avatar
    fix(apkbuild-lint): Remove build-type-not-none lint · 478c7a63
    Kevin Daudt authored and Leo's avatar Leo committed
    Defining `CMAKE_BUILD_TYPE=none` frequently causes debug builds to be
    enabled, resulting either in larger packages, or even in [slower
    applications][0].
    
    The reason this was added was that we want to make sure our build flags
    are being used by the build. According to [this merge request][1], this
    is also the case with build types like `MinSizeRel`, but they are
    prepended. That merge request contains further details and reasoning.
    
    See also [this merge request][2], which moves most packages over to
    `MinSizeRel`, so a lint that suggests to move it back to 'none' is
    counter-productive.
    
    Remove the build-type-not-none linting, as it causes more issues than it
    solves.
    
    [0]:alpine/aports#13276
    [1]:alpine/aports!28731
    [2]:alpine/aports!28826
    478c7a63